Backport mrserb 2fcb8168 master

[evandrojr]

Hi all,

This pull request contains a backport of commit 2fcb8168 from the openjdk/jdk repository.

The commit being backported was authored by Alexey Ivanov on 9 Apr 2024 and was reviewed by Phil Race and
Sergey Bylokhov.

Summary of changes:

This backport fixes bug 8305072 "Win32ShellFolder2.compareTo is inconsistent" by changing the logical
operator in the compareShellFolders method from || to && to ensure consistent sorting behavior of Windows
shell folders.

Files changed:

• jdk/src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java - Fixed comparison logic
• test/jdk/javax/swing/JFileChooser/FileSystemView/Win32FolderSort.java - Added test to verify consistency

The test file has been updated to use the appropriate JDK8 copyright format with the Classpath exception.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/715/head:pull/715
$ git checkout pull/715

Update a local copy of the PR:
$ git checkout pull/715
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/715/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 715

View PR using the GUI difftool:
$ git pr show -t 715

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/715.diff

[bridgekeeper]

Hi @evandrojr, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user evandrojr" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[evandrojr]

Hi @evandrojr, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user evandrojr" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

• I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

[mrserb]

duplicate of #522