8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

[skodanda]

Hello All,

Could you please review a TEST_BUG fix for the JDK 16?

Bug: https://bugs.openjdk.java.net/browse/JDK-8248352

Problem description: The test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can potentially leave the frame open if it fails. If it were not for the frame, the test could be headless. So probably, we can remove the call to showText() from the test and make it headless..

Fix: An argument is added to the test. If "-show" is passed, the test will show UI for visual inspection.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

Reviewers

• Phil Race (@prrace - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/255/head:pull/255
$ git checkout pull/255

[bridgekeeper]

Hi @skodanda, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user skodanda" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@skodanda The following label will be automatically applied to this pull request: 2d.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

[skodanda]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

@skodanda This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open

Reviewed-by: prr, serb, aivanov

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 39 commits pushed to the master branch:

• ae20dd6: 8251496: Fix doclint warnings in jdk.net.httpserver
• b9729cb: 8253284: Zero OrderAccess barrier mappings are incorrect
• 284bbf0: 8253079: DeterministicDump.java fails due to garbage in structure padding
• a4affd5: 8253412: Unsupported GC options passed in JAVA_TOOL_OPTIONS are silently ignored
• 96f722c: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC
• f7b1ce4: 8253447: Remove buggy code introduced by 8249451
• 282b9dc: 8081833: Clean up JVMFlag getter/setter code
• 0e98fc1: 8253237: [REDO] Improve large object handling during evacuation
• d1f9b8a: 8234808: jdb quoted option parsing broken
• d8921ed: 8247281: migrate ObjectMonitor::_object to OopStorage
• ... and 29 more: https://git.openjdk.java.net/jdk/compare/83b2411fd15d0890042ede118a08731ca162b951...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate ae20dd6b9becb3fe846da859504d0a82c00677d1.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@prrace, @mrserb, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (53c1f5f)

[mrserb]

Since you remove the @headful keyword, did you check that the test works fine via mach5? It will now select a completely different set of test systems.

[skodanda]

Dear Sergey, I did test my changes via mach5. It runs successfully on all the 3 platforms. Please find below the result link after running the test using mach5 https://mach5.us.oracle.com/mdash/jobs/skodanda-open-20200902-1336-13932582 Best Regards, K Suman Rajkumaar

…

On 22/09/2020 08:30, Sergey Bylokhov wrote: Since you remove the @headful <https://urldefense.com/v3/__https://github.com/headful__;!!GqivPVa7Brio!PKKl7FS67uragS-DmWxoxkuYTNwPgu4bd6_Zb_6lqAE1grAtcILC40qOfmO2gvwh6lT1Rys-2ibRHA$> keyword, did you check that the test works fine via mach5? It will now select a completely different set of test systems. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/255*issuecomment-696483696__;Iw!!GqivPVa7Brio!PKKl7FS67uragS-DmWxoxkuYTNwPgu4bd6_Zb_6lqAE1grAtcILC40qOfmO2gvwh6lT1RyuZhuffdw$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQ3AYB32LSWT6ONGF6COWK3SHAHNBANCNFSM4RSILQAA__;!!GqivPVa7Brio!PKKl7FS67uragS-DmWxoxkuYTNwPgu4bd6_Zb_6lqAE1grAtcILC40qOfmO2gvwh6lT1RyvF_XZqnw$>.

[aivanov-jdk]

/reviewer credit aivanov

[openjdk]

@aivanov-jdk Only the author (@skodanda) is allowed to issue the reviewer command.

[skodanda]

/integrate

[openjdk]

@skodanda
Your change (at version 53c1f5f) is now ready to be sponsored by a Committer.

[aivanov-jdk]

/sponsor

[openjdk]

@aivanov-jdk @skodanda Since your change was applied there have been 39 commits pushed to the master branch:

• ae20dd6: 8251496: Fix doclint warnings in jdk.net.httpserver
• b9729cb: 8253284: Zero OrderAccess barrier mappings are incorrect
• 284bbf0: 8253079: DeterministicDump.java fails due to garbage in structure padding
• a4affd5: 8253412: Unsupported GC options passed in JAVA_TOOL_OPTIONS are silently ignored
• 96f722c: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC
• f7b1ce4: 8253447: Remove buggy code introduced by 8249451
• 282b9dc: 8081833: Clean up JVMFlag getter/setter code
• 0e98fc1: 8253237: [REDO] Improve large object handling during evacuation
• d1f9b8a: 8234808: jdb quoted option parsing broken
• d8921ed: 8247281: migrate ObjectMonitor::_object to OopStorage
• ... and 29 more: https://git.openjdk.java.net/jdk/compare/83b2411fd15d0890042ede118a08731ca162b951...master

Your commit was automatically rebased without conflicts.

Pushed as commit aa38624.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.