Skip to content

Conversation

@sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented May 23, 2025

The test test/hotspot/jtreg/serviceability/jvmti/vthread/TestPinCaseWithCFLH/TestPinCaseWithCFLH.java was contributed by an external contributor to exercise the -Djdk.tracePinnedThreads=full system property when a javaagent was involved. The jdk.tracePinnedThreads system property is no longer supported by Virtual Threads implementation in mainline. That system property was dropped as part of #21565 in JDK 24.
This update removes the test which is not needed anymore.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8357673: remove test serviceability/jvmti/vthread/TestPinCaseWithCFLH

Issue

  • JDK-8357673: remove test serviceability/jvmti/vthread/TestPinCaseWithCFLH (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25424/head:pull/25424
$ git checkout pull/25424

Update a local copy of the PR:
$ git checkout pull/25424
$ git pull https://git.openjdk.org/jdk.git pull/25424/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25424

View PR using the GUI difftool:
$ git pr show -t 25424

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25424.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2025

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 23, 2025

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357673: remove test serviceability/jvmti/vthread/TestPinCaseWithCFLH

Reviewed-by: amenkov, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 070c84c: 8357178: Simplify Class::componentType
  • 6674771: 8357468: [asan] heap buffer overflow reported in PcDesc::pc_offset() pcDesc.hpp:57

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 23, 2025
@openjdk
Copy link

openjdk bot commented May 23, 2025

@sspitsyn The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented May 23, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 23, 2025
@sspitsyn
Copy link
Contributor Author

Alex and Leonid, thank you for review!

@sspitsyn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 28, 2025

Going to push as commit f30e154.
Since your change was applied there have been 60 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 28, 2025
@openjdk openjdk bot closed this May 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 28, 2025
@openjdk
Copy link

openjdk bot commented May 28, 2025

@sspitsyn Pushed as commit f30e154.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sspitsyn sspitsyn deleted the c15 branch May 28, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated serviceability [email protected]

Development

Successfully merging this pull request may close these issues.

3 participants