8355335: Avoid pattern matching switches in core ClassFile API

[liach]

A few pattern matching switches exist in the core parts of ClassFile API responsible for transformations and parsing. They are likely to be used in early bootstrap, and pattern matching switches require bootstrap methods, which depend on core ClassFile API.

For example, currently BlockCodeBuilderImpl prevents BlockCodeBuilder from being used in early bootstrap; luckily we are currently all using manual labels, and as a result this does not surface in lambdas.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355335: Avoid pattern matching switches in core ClassFile API (Bug - P4)

Reviewers

• Adam Sotona (@asotona - Reviewer)

Reviewers without OpenJDK IDs

• @abdelhak-zaaim (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24807/head:pull/24807
$ git checkout pull/24807

Update a local copy of the PR:
$ git checkout pull/24807
$ git pull https://git.openjdk.org/jdk.git pull/24807/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24807

View PR using the GUI difftool:
$ git pr show -t 24807

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24807.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355335: Avoid pattern matching switches in core ClassFile API

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• adcaf01: 8355237: Upstream AOT test cases from Leyden repo to mainline
• bf8a881: 8352733: Improve RotFontBoundsTest test
• 3571664: 8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms
• ... and 27 more: https://git.openjdk.org/jdk/compare/cc9148ddef95c6ca27ff9fee4c17fb0d4ba7f88e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ae3df67c)

[liach]

Testing: tier1, tier2

[asotona]

Yes, Class-File API use in JDK bootstrap should be safe.

[liach]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit ffe6a4f.
Since your change was applied there have been 31 commits pushed to the master branch:

• 88e0b00: 8353298: AOT cache creation asserts with _array_klasses in an unregistered InstanceKlass
• adcaf01: 8355237: Upstream AOT test cases from Leyden repo to mainline
• bf8a881: 8352733: Improve RotFontBoundsTest test
• ... and 28 more: https://git.openjdk.org/jdk/compare/cc9148ddef95c6ca27ff9fee4c17fb0d4ba7f88e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit ffe6a4f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.