Skip to content

Conversation

@jianglizhou
Copy link
Contributor

@jianglizhou jianglizhou commented Feb 6, 2025

Please review this minor cleanup. The related jtreg test, TracePinnedThreads.java/libTracePinnedThreads.c has already been removed by #21565 work (for JDK-8338383).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349513: Remove unused BUILD_JDK_JTREG_LIBRARIES_JDK_LIBS_libTracePinnedThreads (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23482/head:pull/23482
$ git checkout pull/23482

Update a local copy of the PR:
$ git checkout pull/23482
$ git pull https://git.openjdk.org/jdk.git pull/23482/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23482

View PR using the GUI difftool:
$ git pr show -t 23482

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23482.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 6, 2025

👋 Welcome back jiangli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 6, 2025

@jianglizhou This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349513: Remove unused BUILD_JDK_JTREG_LIBRARIES_JDK_LIBS_libTracePinnedThreads

Reviewed-by: dholmes, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • dd8720e: 8348520: [s390x] Problemlist TestVectorReinterpret.java
  • 4618993: 8349537: Bad copyright in TestArrayStructs.java
  • acb46dd: 8345155: Add /native to native test in FFM
  • d85f651: 8349428: RISC-V: "bad alignment" with -XX:-AvoidUnalignedAccesses after JDK-8347489
  • 7e30791: 8349102: Test compiler/arguments/TestCodeEntryAlignment.java failed: assert(allocates2(pc)) failed: not in CodeBuffer memory
  • 3eb57f6: 8349140: Size optimization (opt-size) build fails after recent PCH changes
  • 3cf04de: 8349132: javac Analyzers should handle non-deferrable errors
  • 30f7162: 8349417: Fix NULL usage from JDK-8346433
  • 64bd8d2: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing
  • 5e1cc08: 8349504: Support platform-specific JUnit tests in jpackage
  • ... and 1 more: https://git.openjdk.org/jdk/compare/aad6664bb6d2b311b3e0cb056afaa9b6534bdbbb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 6, 2025
@openjdk
Copy link

openjdk bot commented Feb 6, 2025

@jianglizhou The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Feb 6, 2025

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial

Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 6, 2025
@jianglizhou
Copy link
Contributor Author

Thanks, @dholmes-ora and @erikj79.

@jianglizhou
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 6, 2025

Going to push as commit eb84702.
Since your change was applied there have been 17 commits pushed to the master branch:

  • f12d2de: 8345212: Since checker should better handle non numeric values
  • 5ec1aae: 8347842: ThreadPoolExecutor specification discusses RuntimePermission
  • 3fbae32: 8349465: [UBSAN] test_os_reserve_between.cpp reported applying non-zero offset to null pointer
  • e0487c7: 8346777: Add missing const declarations and rename variables
  • 2b82e2d: 8347958: Minor compiler cleanups relating to MandatoryWarningHandler
  • 2093bb7: 8346434: Add test for non-automatic service binding
  • dd8720e: 8348520: [s390x] Problemlist TestVectorReinterpret.java
  • 4618993: 8349537: Bad copyright in TestArrayStructs.java
  • acb46dd: 8345155: Add /native to native test in FFM
  • d85f651: 8349428: RISC-V: "bad alignment" with -XX:-AvoidUnalignedAccesses after JDK-8347489
  • ... and 7 more: https://git.openjdk.org/jdk/compare/aad6664bb6d2b311b3e0cb056afaa9b6534bdbbb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 6, 2025
@openjdk openjdk bot closed this Feb 6, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 6, 2025
@openjdk
Copy link

openjdk bot commented Feb 6, 2025

@jianglizhou Pushed as commit eb84702.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants