8333361: ubsan,test : libHeapMonitorTest.cpp:518:9: runtime error: null pointer passed as argument 2, which is declared to never be null

[MBaesken]

The following issue has been observed when running
serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorThreadTest (and some other :tier1 tests)
on Linux with ubsan enabled binaries :

test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.cpp:518:9: runtime error: null pointer passed as argument 2, which is declared to never be null
#0 0xffff80388020 in event_storage_augment_storage test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.cpp:518
#1 0xffff80388020 in event_storage_add test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.cpp:557
#2 0xffff85e695fc in JvmtiExport::post_sampled_object_alloc(JavaThread*, oopDesc*) src/hotspot/share/prims/jvmtiExport.cpp:2926
#3 0xffff85e558b8 in JvmtiObjectAllocEventCollector::generate_call_for_allocated() src/hotspot/share/prims/jvmtiExport.cpp:3074
#4 0xffff85e56c14 in JvmtiSampledObjectAllocEventCollector::~JvmtiSampledObjectAllocEventCollector() src/hotspot/share/prims/jvmtiExport.cpp:3171
#5 0xffff85e56c14 in JvmtiSampledObjectAllocEventCollector::~JvmtiSampledObjectAllocEventCollector() src/hotspot/share/prims/jvmtiExport.cpp:3166
#6 0xffff862ace34 in MemAllocator::Allocation::notify_allocation_jvmti_sampler() src/hotspot/share/gc/shared/memAllocator.cpp:196
#7 0xffff862af7a4 in MemAllocator::Allocation::~Allocation() src/hotspot/share/gc/shared/memAllocator.cpp:87
#8 0xffff862af7a4 in MemAllocator::allocate() const src/hotspot/share/gc/shared/memAllocator.cpp:356
#9 0xffff86dca4dc in CollectedHeap::array_allocate(Klass*, unsigned long, int, bool, JavaThread*) src/hotspot/share/gc/shared/collectedHeap.inline.hpp:41
#10 0xffff86dca4dc in TypeArrayKlass::allocate_common(int, bool, JavaThread*) src/hotspot/share/oops/typeArrayKlass.cpp:93
#11 0xffff86dca4dc in TypeArrayKlass::allocate_common(int, bool, JavaThread*) src/hotspot/share/oops/typeArrayKlass.cpp:89
#12 0xffff857f35c8 in InterpreterRuntime::newarray(JavaThread*, BasicType, int) src/hotspot/share/interpreter/interpreterRuntime.cpp:232
#13 0xffff6b094cf4 ()

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8333361: ubsan,test : libHeapMonitorTest.cpp:518:9: runtime error: null pointer passed as argument 2, which is declared to never be null (Bug - P4)

Reviewers

• Andreas Steiner (@ansteiner - Author)
• Lutz Schmidt (@RealLucy - Reviewer)
• Alex Menkov (@alexmenkov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19804/head:pull/19804
$ git checkout pull/19804

Update a local copy of the PR:
$ git checkout pull/19804
$ git pull https://git.openjdk.org/jdk.git pull/19804/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19804

View PR using the GUI difftool:
$ git pr show -t 19804

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19804.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333361: ubsan,test : libHeapMonitorTest.cpp:518:9: runtime error: null pointer passed as argument 2, which is declared to never be null

Reviewed-by: asteiner, lucy, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• de8ee97: 8334333: MissingResourceCauseTestRun.java fails if run by root
• 265a0f5: 8334490: Normalize string with locale invariant toLowerCase()
• 1b1dba8: 8333358: java/io/IO/IO.java test fails intermittently
• a81e1bf: 8332252: Clean up vmTestbase/vm/share
• 99e4d77: 8333117: Remove support of remote and manual debuggee launchers
• 9ef86da: 8334170: bug6492108.java test failed with exception Image comparison failed at (0, 0) for image 4
• 001d686: 8332587: RISC-V: secondary_super_cache does not scale well
• 5cad0b4: 8322708: Global HTML attributes are not allowed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (970943a5)

[ansteiner]

LGTM

[RealLucy]

LGTM.

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit ed14906.
Since your change was applied there have been 14 commits pushed to the master branch:

• bdd9660: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
• 6a5cb0b: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling
• 880e458: 8333819: Move embedded external addresses from relocation info into separate global table
• e5de26d: 8329032: C2 compiler register allocation support for APX EGPRs
• 4b4a483: 8330699: Obsolete -XX:+UseEmptySlotsInSupers
• 187710e: 8333300: [JVMCI] add support for generational ZGC
• de8ee97: 8334333: MissingResourceCauseTestRun.java fails if run by root
• 265a0f5: 8334490: Normalize string with locale invariant toLowerCase()
• 1b1dba8: 8333358: java/io/IO/IO.java test fails intermittently
• a81e1bf: 8332252: Clean up vmTestbase/vm/share
• ... and 4 more: https://git.openjdk.org/jdk/compare/642084629a9a793a055cba8a950fdb61b7450093...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit ed14906.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.