8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null

[MBaesken]

With ubsan enabled binaries we run into the following issue in HS :tier4 tests :
e.g. vmTestbase/nsk/jvmti/unit/FollowReferences/followref006/TestDescription.jtr

/jdk/test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null
#0 0x7fa7a1049482 in add_option test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.cpp:149
#1 0x7fa7a1049482 in nsk_jvmti_parseOptions test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.cpp:242
#2 0x7fa7a10634cd in Agent_Initialize test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/FollowReferences/followref006/followref006.cpp:216
#3 0x7fa79a9dbb36 in invoke_Agent_OnLoad src/hotspot/share/prims/jvmtiAgent.cpp:609
#4 0x7fa79a9dbb36 in JvmtiAgent::load(outputStream*) src/hotspot/share/prims/jvmtiAgent.cpp:623
#5 0x7fa79a9defd4 in load_agents src/hotspot/share/prims/jvmtiAgentList.cpp:179
#6 0x7fa79a9defd4 in JvmtiAgentList::load_agents() src/hotspot/share/prims/jvmtiAgentList.cpp:190
#7 0x7fa79bdad503 in Threads::create_vm(JavaVMInitArgs*, bool*) src/hotspot/share/runtime/threads.cpp:505
#8 0x7fa79a6e531f in JNI_CreateJavaVM_inner src/hotspot/share/prims/jni.cpp:3581
#9 0x7fa79a6e531f in JNI_CreateJavaVM src/hotspot/share/prims/jni.cpp:3672
#10 0x7fa7a11277d5 in InitializeJVM src/java.base/share/native/libjli/java.c:1550
#11 0x7fa7a11277d5 in JavaMain src/java.base/share/native/libjli/java.c:491
#12 0x7fa7a1130f68 in ThreadJavaMain src/java.base/unix/native/libjli/java_md.c:653
#13 0x7fa7a10df6e9 in start_thread (/lib64/libpthread.so.0+0xa6e9) (BuildId: 2f8d3c2d0f4d7888c2598d2ff6356537f5708a73)
#14 0x7fa7a071550e in clone (/lib64/libc.so.6+0x11850e) (BuildId: f732026552f6adff988b338e92d466bc81a01c37)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null (Bug - P4)(⚠️ The fixVersion in this issue is [24] but the fixVersion in .jcheck/conf is 23, a new backport will be created when this pr is integrated.)

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19557/head:pull/19557
$ git checkout pull/19557

Update a local copy of the PR:
$ git checkout pull/19557
$ git pull https://git.openjdk.org/jdk.git pull/19557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19557

View PR using the GUI difftool:
$ git pr show -t 19557

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19557.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null

Reviewed-by: cjplummer, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• f7dbb98: 8333086: Using Console.println is unnecessarily slow due to JLine initalization
• 9b3694c: 8319822: Use a linear-time algorithm for assert_different_registers()
• f73922b: 8333235: vmTestbase/nsk/jdb/kill/kill001/kill001.java fails with C1
• 5dcb7a6: 8160755: bug6492108.java test fails with exception Image comparison failed at (0, 0) for image 4 in GTK L&F
• 438121b: 8332785: Replace naked uses of UseSharedSpaces with CDSConfig::is_using_archive
• d7d1afb: 8206447: InflaterInputStream.skip receives long but it's limited to Integer.MAX_VALUE
• 7acfba2: 8327650: Test java/nio/channels/DatagramChannel/StressNativeSignal.java timed out
• c5c0867: 8333252: C2: assert(assertion_predicate_has_loop_opaque_node(iff)) failed: must find OpaqueLoop* nodes
• d85b0ca: 8332457: Examine startup overheads from JDK-8294961
• 326dbb1: 8312436: CompletableFuture never completes when 'Throwable.toString()' method throws Exception
• ... and 4 more: https://git.openjdk.org/jdk/compare/2c1b311f81319cee1af574526a91424c2577b78c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1a121bc4)

[plummercj]

Looks good.

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 880c6b4.
Since your change was applied there have been 25 commits pushed to the master branch:

• c7d2841: 8332070: Convert package.html files in java.management to package-info.java
• 7ef2831: 8333644: C2: assert(is_Bool()) failed: invalid node class: Phi
• 8f07853: 8333410: [AArch64] Clean unused classes in nativeInst_aarch64.hpp
• 6f690a5: 8333177: Invalid value used for enum Cell in ciTypeFlow::get_start_state
• b351b5f: 8331736: C2: Live Node limit exceeded limit after JDK-8316991
• b3f540d: 8332921: Ctrl+C does not call shutdown hooks after JLine upgrade
• 3089412: 8326716: JVMTI spec: clarify what nullptr means for C/C++ developers
• ca93907: 8256828: ostream::print_cr() truncates buffer in copy-through case
• 60ea17e: 8311177: Switching to interpreter only mode in carrier thread can lead to crashes
• 7564949: 8291643: Consider omitting type annotations from type error diagnostics
• ... and 15 more: https://git.openjdk.org/jdk/compare/2c1b311f81319cee1af574526a91424c2577b78c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 880c6b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.