Skip to content

Commit f744fe7

Browse files
committed
Cleanup.
1 parent fad7bb5 commit f744fe7

File tree

4 files changed

+9
-14
lines changed

4 files changed

+9
-14
lines changed

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Enter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ public void visitTopLevel(JCCompilationUnit tree) {
376376
Name name = names.package_info;
377377
ClassSymbol c = syms.enterClass(tree.modle, name, tree.packge);
378378
c.flatname = names.fromString(tree.packge + "." + name);
379-
c.sourcefile = tree.sourcefile;
379+
c.classfile = c.sourcefile = tree.sourcefile;
380380
c.completer = Completer.NULL_COMPLETER;
381381
c.members_field = WriteableScope.create(c);
382382
tree.packge.package_info = c;
@@ -495,7 +495,7 @@ public void visitClassDef(JCClassDecl tree) {
495495
// Fill out class fields.
496496
c.completer = Completer.NULL_COMPLETER; // do not allow the initial completer linger on.
497497
c.flags_field = chk.checkFlags(tree.pos(), tree.mods.flags, c, tree);
498-
c.sourcefile = env.toplevel.sourcefile;
498+
c.classfile = c.sourcefile = env.toplevel.sourcefile;
499499
c.members_field = WriteableScope.create(c);
500500
c.clearAnnotationMetadata();
501501

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ private void enterModule(JCCompilationUnit toplevel, ClassSymbol c, Set<ModuleSy
329329
}
330330
}
331331
sym.completer = getSourceCompleter(toplevel);
332-
sym.module_info.sourcefile = toplevel.sourcefile;
332+
sym.module_info.classfile = sym.module_info.sourcefile = toplevel.sourcefile;
333333
decl.sym = sym;
334334

335335
if (multiModuleMode || modules.isEmpty()) {

src/jdk.compiler/share/classes/com/sun/tools/javac/model/JavacElements.java

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -735,21 +735,16 @@ public JavaFileObject getFileObjectOf(Element e) {
735735
if (((PackageSymbol) sym).package_info == null) {
736736
yield null;
737737
}
738-
yield getFileObjectOf(((PackageSymbol) sym).package_info);
738+
yield ((PackageSymbol) sym).package_info.classfile;
739739
}
740740
case MDL -> {
741741
ModuleSymbol msym = (ModuleSymbol) sym;
742-
yield getFileObjectOf(msym.module_info);
742+
yield msym.module_info.classfile;
743743
}
744-
case TYP -> getFileObjectOf((ClassSymbol) sym);
745-
default -> getFileObjectOf(sym.enclClass());
744+
case TYP -> ((ClassSymbol) sym).classfile;
745+
default -> sym.enclClass().classfile;
746746
};
747747
}
748-
//where:
749-
private static JavaFileObject getFileObjectOf(ClassSymbol sym) {
750-
return sym.classfile != null ? sym.classfile
751-
: sym.sourcefile;
752-
}
753748

754749
/**
755750
* Returns the tree node and compilation unit corresponding to this

test/langtools/tools/javac/processing/model/element/TestFileObjectOf.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323

2424
/*
2525
* @test
26-
* @bug 9999999
27-
* @summary XXX
26+
* @bug 8224922
27+
* @summary Verify the behavior of the Elements.getFileObjectOf
2828
* @library /tools/lib
2929
* @modules jdk.compiler/com.sun.tools.javac.api
3030
* jdk.compiler/com.sun.tools.javac.main

0 commit comments

Comments
 (0)