Skip to content

Commit e7ca8c7

Browse files
david-beaumontSendaoYan
authored andcommitted
8365436: ImageReaderTest fails when jmods directory not present
Reviewed-by: sgehwolf, alanb
1 parent f364fca commit e7ca8c7

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

test/jdk/jdk/internal/jimage/ImageReaderTest.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,12 @@
2525
import jdk.internal.jimage.ImageReader.Node;
2626
import jdk.test.lib.compiler.InMemoryJavaCompiler;
2727
import jdk.test.lib.util.JarBuilder;
28+
import jdk.tools.jlink.internal.LinkableRuntimeImage;
29+
import org.junit.jupiter.api.Assumptions;
2830
import org.junit.jupiter.api.Test;
2931
import org.junit.jupiter.api.TestInstance;
3032
import org.junit.jupiter.params.ParameterizedTest;
3133
import org.junit.jupiter.params.provider.ValueSource;
32-
import org.opentest4j.TestSkippedException;
3334
import tests.Helper;
3435
import tests.JImageGenerator;
3536

@@ -54,6 +55,7 @@
5455
* @test
5556
* @summary Tests for ImageReader.
5657
* @modules java.base/jdk.internal.jimage
58+
* jdk.jlink/jdk.tools.jlink.internal
5759
* jdk.jlink/jdk.tools.jimage
5860
* @library /test/jdk/tools/lib
5961
* /test/lib
@@ -214,15 +216,15 @@ public String toString() {
214216

215217
/// Returns the helper for building JAR and jimage files.
216218
private static Helper getHelper() {
219+
Helper helper;
217220
try {
218-
Helper helper = Helper.newHelper();
219-
if (helper == null) {
220-
throw new TestSkippedException("Cannot create test helper (exploded image?)");
221-
}
222-
return helper;
221+
boolean isLinkableRuntime = LinkableRuntimeImage.isLinkableRuntime();
222+
helper = Helper.newHelper(isLinkableRuntime);
223223
} catch (IOException e) {
224224
throw new RuntimeException(e);
225225
}
226+
Assumptions.assumeTrue(helper != null, "Cannot create test helper, skipping test!");
227+
return helper;
226228
}
227229

228230
/// Loads and performs actions on classes stored in a given `ImageReader`.

0 commit comments

Comments
 (0)