Skip to content

Commit e3e0fd5

Browse files
naotojpull[bot]
authored andcommitted
8321409: Console read line with zero out should zero out underlying buffer in JLine (redux)
Reviewed-by: alanb
1 parent 13edc9f commit e3e0fd5

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

src/jdk.internal.le/share/classes/jdk/internal/org/jline/JdkConsoleProviderImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public char[] readPassword(String fmt, Object ... args) {
114114
} catch (EndOfFileException eofe) {
115115
return null;
116116
} finally {
117-
jline.getBuffer().zeroOut();
117+
jline.zeroOut();
118118
}
119119
}
120120

src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReader.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -750,4 +750,9 @@ enum SuggestionType {
750750
void setAutosuggestion(SuggestionType type);
751751

752752
SuggestionType getAutosuggestion();
753+
754+
// JDK specific modification
755+
default void zeroOut() {
756+
throw new UnsupportedOperationException();
757+
}
753758
}

src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/LineReaderImpl.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6250,4 +6250,10 @@ private void rebind(KeyMap<Binding> keyMap, String operation, String prevBinding
62506250
}
62516251
}
62526252

6253+
// JDK specific modification
6254+
@Override
6255+
public void zeroOut() {
6256+
buf.zeroOut();
6257+
parsedLine = null;
6258+
}
62536259
}

0 commit comments

Comments
 (0)