Skip to content

Commit d9cbdb6

Browse files
committed
last nits (comments only) ironed out
1 parent 8d86e25 commit d9cbdb6

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

src/hotspot/os/posix/signals_posix.cpp

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -455,23 +455,21 @@ extern "C" JNIEXPORT int JVM_handle_linux_signal(int signo, siginfo_t* siginfo,
455455
///// Synchronous (non-deferrable) error signals (ILL, SEGV, FPE, BUS, TRAP):
456456

457457
// These signals are special because they cannot be deferred and, if they
458-
// happen while delivery is blocked for the receiving thread, will cause UB
459-
// (in practice typically resulting in sudden process deaths or hangs, see
460-
// JDK-8252533). So we must take care never to block them when we cannot be
461-
// absolutely sure they won't happen. In practice, this is always.
458+
// happen while delivery is blocked for the receiving thread, will cause UB
459+
// (in practice typically resulting in sudden process deaths or hangs, see
460+
// JDK-8252533). So we must take care never to block them when we cannot be
461+
// absolutely sure they won't happen. In practice, this is always.
462462
//
463463
// Relevant Posix quote:
464-
// <quote>
465-
// The behavior of a process is undefined after it ignores a SIGFPE, SIGILL,
466-
// SIGSEGV, or SIGBUS signal that was not generated by kill(), sigqueue(), or
467-
// raise().
468-
// </quote>
464+
// "The behavior of a process is undefined after it ignores a SIGFPE, SIGILL,
465+
// SIGSEGV, or SIGBUS signal that was not generated by kill(), sigqueue(), or
466+
// raise()."
469467
//
470468
// We also include SIGTRAP in that list of never-to-block-signals. While not
471-
// mentioned by the Posix documentation, in our (SAPs) experience blocking it
472-
// causes similar problems. Beside, during normal operation - outside of error
473-
// handling - SIGTRAP may be used for implicit NULL checking, so it makes sense
474-
// to never block it.
469+
// mentioned by the Posix documentation, in our (SAPs) experience blocking it
470+
// causes similar problems. Beside, during normal operation - outside of error
471+
// handling - SIGTRAP may be used for implicit NULL checking, so it makes sense
472+
// to never block it.
475473
//
476474
// We deal with those signals in two ways:
477475
// - we just never explicitly block them, which includes not accidentally blocking

0 commit comments

Comments
 (0)