Skip to content

Commit d8921ed

Browse files
Daniel D. Daughertyfiskdcubed-ojdk
committed
8247281: migrate ObjectMonitor::_object to OopStorage
Co-authored-by: Erik Österlund <[email protected]> Co-authored-by: Daniel Daugherty <[email protected]> Reviewed-by: eosterlund, coleenp, dholmes, stefank, kbarrett, rkennke, sspitsyn
1 parent f800af9 commit d8921ed

37 files changed

+211
-344
lines changed

src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ G1GCPhaseTimes::G1GCPhaseTimes(STWGCTimer* gc_timer, uint max_gc_threads) :
5858

5959
// Root scanning phases
6060
_gc_par_phases[ThreadRoots] = new WorkerDataArray<double>("ThreadRoots", "Thread Roots (ms):", max_gc_threads);
61-
_gc_par_phases[ObjectSynchronizerRoots] = new WorkerDataArray<double>("ObjectSynchronizerRoots", "ObjectSynchronizer Roots (ms):", max_gc_threads);
6261
_gc_par_phases[CLDGRoots] = new WorkerDataArray<double>("CLDGRoots", "CLDG Roots (ms):", max_gc_threads);
6362
AOT_ONLY(_gc_par_phases[AOTCodeRoots] = new WorkerDataArray<double>("AOTCodeRoots", "AOT Root Scan (ms):", max_gc_threads);)
6463
_gc_par_phases[CMRefRoots] = new WorkerDataArray<double>("CMRefRoots", "CM RefProcessor Roots (ms):", max_gc_threads);

src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ class G1GCPhaseTimes : public CHeapObj<mtGC> {
4848
GCWorkerStart,
4949
ExtRootScan,
5050
ThreadRoots,
51-
ObjectSynchronizerRoots,
5251
CLDGRoots,
5352
AOT_ONLY(AOTCodeRoots COMMA)
5453
CMRefRoots,

src/hotspot/share/gc/g1/g1RootProcessor.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -180,13 +180,6 @@ void G1RootProcessor::process_vm_roots(G1RootClosures* closures,
180180
uint worker_id) {
181181
OopClosure* strong_roots = closures->strong_oops();
182182

183-
{
184-
G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::ObjectSynchronizerRoots, worker_id);
185-
if (_process_strong_tasks.try_claim_task(G1RP_PS_ObjectSynchronizer_oops_do)) {
186-
ObjectSynchronizer::oops_do(strong_roots);
187-
}
188-
}
189-
190183
#if INCLUDE_AOT
191184
if (UseAOT) {
192185
G1GCParPhaseTimesTracker x(phase_times, G1GCPhaseTimes::AOTCodeRoots, worker_id);

src/hotspot/share/gc/g1/g1RootProcessor.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ class G1RootProcessor : public StackObj {
5454

5555
enum G1H_process_roots_tasks {
5656
G1RP_PS_Universe_oops_do,
57-
G1RP_PS_ObjectSynchronizer_oops_do,
5857
G1RP_PS_Management_oops_do,
5958
G1RP_PS_ClassLoaderDataGraph_oops_do,
6059
G1RP_PS_jvmti_oops_do,

src/hotspot/share/gc/parallel/psParallelCompact.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2010,10 +2010,6 @@ static void mark_from_roots_work(ParallelRootType::Value root_type, uint worker_
20102010
PCMarkAndPushClosure mark_and_push_closure(cm);
20112011

20122012
switch (root_type) {
2013-
case ParallelRootType::object_synchronizer:
2014-
ObjectSynchronizer::oops_do(&mark_and_push_closure);
2015-
break;
2016-
20172013
case ParallelRootType::class_loader_data:
20182014
{
20192015
CLDToOopClosure cld_closure(&mark_and_push_closure, ClassLoaderData::_claim_strong);
@@ -2224,7 +2220,6 @@ void PSParallelCompact::adjust_roots(ParCompactionManager* cm) {
22242220

22252221
// General strong roots.
22262222
Threads::oops_do(&oop_closure, NULL);
2227-
ObjectSynchronizer::oops_do(&oop_closure);
22282223
OopStorageSet::strong_oops_do(&oop_closure);
22292224
CLDToOopClosure cld_closure(&oop_closure, ClassLoaderData::_claim_strong);
22302225
ClassLoaderDataGraph::cld_do(&cld_closure);

src/hotspot/share/gc/parallel/psRootType.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ class ParallelRootType : public AllStatic {
3434
// The order reflects the order these roots are to be processed,
3535
// We do not want any holes in the enum as we enumerate these values by incrementing them.
3636
enum Value {
37-
object_synchronizer,
3837
class_loader_data,
3938
code_cache,
4039
//"threads" are handled in parallel as a special case

src/hotspot/share/gc/parallel/psScavenge.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,6 @@ static void scavenge_roots_work(ParallelRootType::Value root_type, uint worker_i
9292
PSPromoteRootsClosure roots_to_old_closure(pm);
9393

9494
switch (root_type) {
95-
case ParallelRootType::object_synchronizer:
96-
ObjectSynchronizer::oops_do(&roots_closure);
97-
break;
98-
9995
case ParallelRootType::class_loader_data:
10096
{
10197
PSScavengeCLDClosure cld_closure(pm);

src/hotspot/share/gc/shared/genCollectedHeap.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -817,9 +817,6 @@ void GenCollectedHeap::process_roots(StrongRootsScope* scope,
817817
bool is_par = scope->n_threads() > 1;
818818
Threads::possibly_parallel_oops_do(is_par, strong_roots, roots_from_code_p);
819819

820-
if (_process_strong_tasks->try_claim_task(GCH_PS_ObjectSynchronizer_oops_do)) {
821-
ObjectSynchronizer::oops_do(strong_roots);
822-
}
823820
#if INCLUDE_AOT
824821
if (UseAOT && _process_strong_tasks->try_claim_task(GCH_PS_aot_oops_do)) {
825822
AOTLoader::oops_do(strong_roots);

src/hotspot/share/gc/shared/genCollectedHeap.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ class GenCollectedHeap : public CollectedHeap {
105105

106106
// The set of potentially parallel tasks in root scanning.
107107
enum GCH_strong_roots_tasks {
108-
GCH_PS_ObjectSynchronizer_oops_do,
109108
GCH_PS_OopStorageSet_oops_do,
110109
GCH_PS_ClassLoaderDataGraph_oops_do,
111110
GCH_PS_CodeCache_oops_do,

src/hotspot/share/gc/shared/oopStorageSet.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class OopStorageSet : public AllStatic {
3838
public:
3939
// Must be updated when new OopStorages are introduced
4040
static const uint strong_count = 4 JVMTI_ONLY(+ 1);
41-
static const uint weak_count = 4 JFR_ONLY(+ 1);
41+
static const uint weak_count = 5 JFR_ONLY(+ 1);
4242
static const uint all_count = strong_count + weak_count;
4343

4444
private:

0 commit comments

Comments
 (0)