Skip to content

Commit be0dca0

Browse files
author
Sandhya Viswanathan
committed
8339698: x86 unused andw/orw/xorw/addw encoding could be removed
Reviewed-by: kvn, jbhateja, qamai
1 parent 64a79d8 commit be0dca0

File tree

2 files changed

+0
-26
lines changed

2 files changed

+0
-26
lines changed

src/hotspot/cpu/x86/assembler_x86.cpp

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1405,12 +1405,6 @@ void Assembler::addb(Register dst, int imm8) {
14051405
emit_arith_b(0x80, 0xC0, dst, imm8);
14061406
}
14071407

1408-
void Assembler::addw(Register dst, Register src) {
1409-
emit_int8(0x66);
1410-
(void)prefix_and_encode(dst->encoding(), src->encoding());
1411-
emit_arith(0x03, 0xC0, dst, src);
1412-
}
1413-
14141408
void Assembler::addw(Address dst, int imm16) {
14151409
InstructionMark im(this);
14161410
emit_int8(0x66);
@@ -1632,11 +1626,6 @@ void Assembler::andb(Address dst, Register src) {
16321626
emit_operand(src, dst, 0);
16331627
}
16341628

1635-
void Assembler::andw(Register dst, Register src) {
1636-
(void)prefix_and_encode(dst->encoding(), src->encoding());
1637-
emit_arith(0x23, 0xC0, dst, src);
1638-
}
1639-
16401629
void Assembler::andl(Address dst, int32_t imm32) {
16411630
InstructionMark im(this);
16421631
prefix(dst);
@@ -4230,11 +4219,6 @@ void Assembler::notl(Register dst) {
42304219
emit_int16((unsigned char)0xF7, (0xD0 | encode));
42314220
}
42324221

4233-
void Assembler::orw(Register dst, Register src) {
4234-
(void)prefix_and_encode(dst->encoding(), src->encoding());
4235-
emit_arith(0x0B, 0xC0, dst, src);
4236-
}
4237-
42384222
void Assembler::orl(Address dst, int32_t imm32) {
42394223
InstructionMark im(this);
42404224
prefix(dst);
@@ -6803,11 +6787,6 @@ void Assembler::xorb(Address dst, Register src) {
68036787
emit_operand(src, dst, 0);
68046788
}
68056789

6806-
void Assembler::xorw(Register dst, Register src) {
6807-
(void)prefix_and_encode(dst->encoding(), src->encoding());
6808-
emit_arith(0x33, 0xC0, dst, src);
6809-
}
6810-
68116790
void Assembler::xorw(Register dst, Address src) {
68126791
InstructionMark im(this);
68136792
emit_int8(0x66);

src/hotspot/cpu/x86/assembler_x86.hpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1068,7 +1068,6 @@ class Assembler : public AbstractAssembler {
10681068
void addb(Address dst, int imm8);
10691069
void addb(Address dst, Register src);
10701070
void addb(Register dst, int imm8);
1071-
void addw(Register dst, Register src);
10721071
void addw(Address dst, int imm16);
10731072
void addw(Address dst, Register src);
10741073

@@ -1120,7 +1119,6 @@ class Assembler : public AbstractAssembler {
11201119
void vaesdec(XMMRegister dst, XMMRegister nds, XMMRegister src, int vector_len);
11211120
void vaesdeclast(XMMRegister dst, XMMRegister nds, XMMRegister src, int vector_len);
11221121

1123-
void andw(Register dst, Register src);
11241122
void andb(Address dst, Register src);
11251123

11261124
void andl(Address dst, int32_t imm32);
@@ -1824,8 +1822,6 @@ class Assembler : public AbstractAssembler {
18241822
#endif
18251823
void btq(Register dst, Register src);
18261824

1827-
void orw(Register dst, Register src);
1828-
18291825
void orl(Address dst, int32_t imm32);
18301826
void orl(Register dst, int32_t imm32);
18311827
void orl(Register dst, Address src);
@@ -2342,7 +2338,6 @@ class Assembler : public AbstractAssembler {
23422338

23432339
void xorb(Address dst, Register src);
23442340
void xorb(Register dst, Address src);
2345-
void xorw(Register dst, Register src);
23462341
void xorw(Register dst, Address src);
23472342

23482343
void xorq(Register dst, Address src);

0 commit comments

Comments
 (0)