Improvement: replace all occurrences of the .equals("") usages with .isEmpty()

Author: doom369

make/jdk/src/classes/build/tools/compileproperties/CompileProperties.java

@@ -260,7 +260,7 @@ private static boolean createFile(String propertiesPath, String outputPath,
             }
 
             String packageString = "";
-            if (packageName != null && !packageName.equals("")) {
+            if (packageName != null && !packageName.isEmpty()) {
                 packageString = "package " + packageName + ";\n\n";
             }
 

make/jdk/src/classes/build/tools/generatebreakiteratordata/CharacterCategory.java

@@ -119,7 +119,7 @@ public static void main(String[] args) {
          * Generates data in older format (1.4.X and earlier) and creates
          * the old CategoryMap if "oldFilename" is not null.
          */
-        if (!oldDatafile.equals("")) {
+        if (!oldDatafile.isEmpty()) {
             generateOldData();
             generateOldDatafile();
         }

make/jdk/src/classes/build/tools/generatebreakiteratordata/GenerateBreakIteratorData.java

@@ -161,8 +161,8 @@ private static void processArgs(String[] args) {
      * Make locale name ("_language_country_valiant")
      */
     private static String getLocaleName() {
-        if (language.equals("")) {
-            if (!country.equals("") || !valiant.equals("")) {
+        if (language.isEmpty()) {
+            if (!country.isEmpty() || !valiant.isEmpty()) {
                 language = "en";
             } else {
                 return "";
@@ -172,10 +172,10 @@ private static String getLocaleName() {
         StringBuffer sb = new StringBuffer();
         sb.append('_');
         sb.append(language);
-        if (!country.equals("") || !valiant.equals("")) {
+        if (!country.isEmpty() || !valiant.isEmpty()) {
             sb.append('_');
             sb.append(country);
-            if (!valiant.equals("")) {
+            if (!valiant.isEmpty()) {
                 sb.append('_');
                 sb.append(valiant);
             }

make/jdk/src/classes/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java

@@ -2022,7 +2022,7 @@ protected void writeTables(String datafile) {
         final String outputDir;
         String tmpbuf = GenerateBreakIteratorData.getOutputDirectory();
 
-        if (tmpbuf.equals("")) {
+        if (tmpbuf.isEmpty()) {
             filename = datafile;
             outputDir = "";
         } else {
@@ -2039,7 +2039,7 @@ protected void writeTables(String datafile) {
         }
 
         try {
-            if (!outputDir.equals("")) {
+            if (!outputDir.isEmpty()) {
                 new File(outputDir).mkdirs();
             }
             BufferedOutputStream out = new BufferedOutputStream(new FileOutputStream(filename));

make/jdk/src/classes/build/tools/pandocfilter/json/JSONParser.java

@@ -375,7 +375,7 @@ public JSONValue parseValue() {
     }
 
     public JSONValue parse(String s) {
-        if (s == null || s.equals("")) {
+        if (s == null || s.isEmpty()) {
             return null;
         }
 

make/langtools/tools/anttasks/SelectToolTask.java

@@ -151,7 +151,7 @@ public void execute() {
         }
 
         // finally, return required values, if any
-        if (toolProperty != null && !(toolName == null || toolName.equals(""))) {
+        if (toolProperty != null && !(toolName == null || toolName.isEmpty())) {
             p.setProperty(toolProperty, toolName);
 
             if (argsProperty != null && toolArgs != null)
@@ -169,7 +169,7 @@ void showGUI(Properties fileProps) {
         toolName = tool.toolName;
         toolArgs = argsField.getText();
         if (defaultCheck.isSelected()) {
-            if (toolName.equals("")) {
+            if (toolName.isEmpty()) {
                 fileProps.remove("tool.name");
                 fileProps.remove("tool.bootstrap");
             } else {
@@ -243,7 +243,7 @@ public void focusLost(FocusEvent e) {
 
         final JOptionPane p = new JOptionPane(body);
         okButton = new JButton("OK");
-        okButton.setEnabled(toolProperty == null || (toolName != null && !toolName.equals("")));
+        okButton.setEnabled(toolProperty == null || (toolName != null && !toolName.isEmpty()));
         okButton.addActionListener(e -> {
             JDialog d = (JDialog) SwingUtilities.getAncestorOfClass(JDialog.class, p);
             d.setVisible(false);
@@ -304,7 +304,7 @@ String getDefaultArgsForTool(Properties props, ToolChoices tool) {
         if (tool == null)
             return "";
         String toolName = tool.toolName;
-        return toolName.equals("") ? "" : props.getProperty(toolName + ".args", "");
+        return toolName.isEmpty() ? "" : props.getProperty(toolName + ".args", "");
     }
 
     // Ant task parameters

make/langtools/tools/compileproperties/CompileProperties.java

@@ -247,7 +247,7 @@ private boolean createFile(String propertiesPath, String outputPath,
             }
 
             String packageString = "";
-            if (packageName != null && !packageName.equals("")) {
+            if (packageName != null && !packageName.isEmpty()) {
                 packageString = "package " + packageName + ";\n\n";
             }
 

src/demo/share/java2d/J2DBench/src/j2dbench/tests/iio/InputImageTests.java

@@ -184,7 +184,7 @@ private static void initIIOReadFormats() {
             String klass = spi.getClass().getName();
             String format = spi.getFormatNames()[0].toLowerCase();
             String suffix = spi.getFileSuffixes()[0].toLowerCase();
-            if (suffix == null || suffix.equals("")) {
+            if (suffix == null || suffix.isEmpty()) {
                 suffix = format;
             }
             String shortName;

src/demo/share/java2d/J2DBench/src/j2dbench/tests/iio/OutputImageTests.java

@@ -143,7 +143,7 @@ private static void initIIOWriteFormats() {
             String klass = spi.getClass().getName();
             String format = spi.getFormatNames()[0].toLowerCase();
             String suffix = spi.getFileSuffixes()[0].toLowerCase();
-            if (suffix == null || suffix.equals("")) {
+            if (suffix == null || suffix.isEmpty()) {
                 suffix = format;
             }
             String shortName;

src/demo/share/jfc/TableExample/JDBCAdapter.java

@@ -246,7 +246,7 @@ public void setValueAt(Object value, int row, int column) {
             // that editing is possible, we'll just lock on everything.
             for (int col = 0; col < getColumnCount(); col++) {
                 String colName = getColumnName(col);
-                if (colName.equals("")) {
+                if (colName.isEmpty()) {
                     continue;
                 }
                 if (col != 0) {