Skip to content

Commit ae690b2

Browse files
committed
Remove duplicated Carrying statement and indent vthread stack
1 parent 1a75277 commit ae690b2

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

src/hotspot/share/runtime/javaThread.cpp

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1522,14 +1522,8 @@ void JavaThread::print_on(outputStream *st, bool print_extended_info) const {
15221522
Thread::print_on(st, print_extended_info);
15231523
// print guess for valid stack memory region (assume 4K pages); helps lock debugging
15241524
st->print_cr("[" INTPTR_FORMAT "]", (intptr_t)last_Java_sp() & ~right_n_bits(12));
1525-
if (thread_oop != nullptr) {
1526-
if (is_vthread_mounted()) {
1527-
oop vt = vthread();
1528-
assert(vt != nullptr, "");
1529-
st->print_cr(" Carrying virtual thread #" INT64_FORMAT, (int64_t)java_lang_Thread::thread_id(vt));
1530-
} else {
1531-
st->print_cr(" java.lang.Thread.State: %s", java_lang_Thread::thread_status_name(thread_oop));
1532-
}
1525+
if (thread_oop != nullptr && !is_vthread_mounted()) {
1526+
st->print_cr(" java.lang.Thread.State: %s", java_lang_Thread::thread_status_name(thread_oop));
15331527
}
15341528
#ifndef PRODUCT
15351529
_safepoint_state->print_on(st);

src/hotspot/share/runtime/threads.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1328,13 +1328,12 @@ void Threads::print_on(outputStream* st, bool print_stacks,
13281328
if (internal_format) {
13291329
p->trace_stack();
13301330
} else {
1331-
p->print_stack_on(st);
13321331
oop thread_oop = p->threadObj();
13331332
if (thread_oop != nullptr) {
13341333
if (p->is_vthread_mounted()) {
13351334
oop vt = p->vthread();
13361335
assert(vt != nullptr, "");
1337-
st->print_cr(" Carrying virtual thread #" INT64_FORMAT, (int64_t)java_lang_Thread::thread_id(vt));
1336+
st->print_cr(" \tCarrying virtual thread #" INT64_FORMAT, (int64_t)java_lang_Thread::thread_id(vt));
13381337
// Very slightly modified copy of what GetStackTraceClosure does
13391338
const int max_depth = MaxJavaStackTraceDepth;
13401339
const bool skip_hidden = !ShowHiddenFrames;
@@ -1347,11 +1346,13 @@ void Threads::print_on(outputStream* st, bool print_stacks,
13471346
vfst.method()->is_continuation_enter_intrinsic())) {
13481347
continue;
13491348
}
1349+
st->print("\t"); // Indent
13501350
java_lang_Throwable::print_stack_element(st, vfst.method(), vfst.bci());
13511351
total_count++;
13521352
}
13531353
}
13541354
}
1355+
p->print_stack_on(st);
13551356
}
13561357
}
13571358
st->cr();

0 commit comments

Comments
 (0)