Skip to content

Commit a07b72b

Browse files
committed
8344346: java/net/httpclient/ShutdownNow.java fails with java.lang.AssertionError: client was still running, but exited after further delay: timeout should be adjusted
Reviewed-by: jpai
1 parent 2ea0364 commit a07b72b

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

test/jdk/java/net/httpclient/ShutdownNow.java

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
* isTerminated.
3131
* @library /test/lib /test/jdk/java/net/httpclient/lib
3232
* @build jdk.httpclient.test.lib.http2.Http2TestServer jdk.test.lib.net.SimpleSSLContext
33+
* jdk.test.lib.RandomFactory jdk.test.lib.Utils
3334
* ReferenceTracker
3435
* @run testng/othervm
3536
* -Djdk.internal.httpclient.debug=true
@@ -41,8 +42,6 @@
4142
import java.io.IOException;
4243
import java.io.InputStream;
4344
import java.io.OutputStream;
44-
import java.net.InetAddress;
45-
import java.net.InetSocketAddress;
4645
import java.net.URI;
4746
import java.net.http.HttpClient;
4847
import java.net.http.HttpClient.Redirect;
@@ -58,20 +57,12 @@
5857
import java.util.concurrent.CompletionException;
5958
import java.util.concurrent.ConcurrentHashMap;
6059
import java.util.concurrent.ExecutionException;
61-
import java.util.concurrent.ExecutorService;
62-
import java.util.concurrent.Executors;
63-
import java.util.concurrent.RejectedExecutionException;
64-
import java.util.concurrent.TimeUnit;
6560
import java.util.concurrent.atomic.AtomicLong;
6661
import jdk.httpclient.test.lib.common.HttpServerAdapters;
67-
import jdk.httpclient.test.lib.http2.Http2TestServer;
6862
import javax.net.ssl.SSLContext;
69-
import javax.net.ssl.SSLHandshakeException;
7063

71-
import com.sun.net.httpserver.HttpServer;
72-
import com.sun.net.httpserver.HttpsConfigurator;
73-
import com.sun.net.httpserver.HttpsServer;
7464
import jdk.test.lib.RandomFactory;
65+
import jdk.test.lib.Utils;
7566
import jdk.test.lib.net.SimpleSSLContext;
7667
import org.testng.annotations.AfterTest;
7768
import org.testng.annotations.BeforeTest;
@@ -211,7 +202,7 @@ void testConcurrent(String uriString) throws Exception {
211202
}
212203
CompletableFuture.allOf(responses.toArray(new CompletableFuture<?>[0])).get();
213204
} finally {
214-
if (client.awaitTermination(Duration.ofMillis(2500))) {
205+
if (client.awaitTermination(Duration.ofMillis(Utils.adjustTimeout(1000)))) {
215206
out.println("Client terminated within expected delay");
216207
assertTrue(client.isTerminated());
217208
} else {
@@ -277,7 +268,7 @@ void testSequential(String uriString) throws Exception {
277268
}).thenCompose((c) -> c).get();
278269
}
279270
} finally {
280-
if (client.awaitTermination(Duration.ofMillis(2500))) {
271+
if (client.awaitTermination(Duration.ofMillis(Utils.adjustTimeout(1000)))) {
281272
out.println("Client terminated within expected delay");
282273
assertTrue(client.isTerminated());
283274
} else {

0 commit comments

Comments
 (0)