Skip to content

Commit 90c73d0

Browse files
committed
8259569: gtest os.dll_address_to_function_and_library_name_vm fails
Reviewed-by: dcubed
1 parent 536082d commit 90c73d0

File tree

1 file changed

+1
-36
lines changed

1 file changed

+1
-36
lines changed

test/hotspot/gtest/runtime/test_os.cpp

Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,7 @@ TEST_VM(os, pagesizes_test_print) {
698698
ASSERT_EQ(strcmp(expected, buffer), 0);
699699
}
700700

701-
TEST_VM(os, DISABLED_dll_address_to_function_and_library_name) {
701+
TEST_VM(os, dll_address_to_function_and_library_name) {
702702
char tmp[1024];
703703
char output[1024];
704704
stringStream st(output, sizeof(output));
@@ -737,15 +737,6 @@ TEST_VM(os, DISABLED_dll_address_to_function_and_library_name) {
737737
EXPECT_CONTAINS(output, "Threads");
738738
EXPECT_CONTAINS(output, "create_vm");
739739
EXPECT_CONTAINS(output, "jvm"); // "jvm.dll" or "libjvm.so" or similar
740-
#ifndef _WIN32 // Demangler gives us no arguments on Windows
741-
if (demangle) {
742-
if (strip_arguments) {
743-
EXPECT_DOES_NOT_CONTAIN(output, "(");
744-
} else {
745-
EXPECT_CONTAINS(output, "(");
746-
}
747-
}
748-
#endif // _WIN32
749740
LOG("%s", output);
750741

751742
// Test truncation on scratch buffer
@@ -767,31 +758,5 @@ TEST_VM(os, DISABLED_dll_address_to_function_and_library_name) {
767758
shorten_paths, demangle));
768759
EXPECT_CONTAINS(output, "jvm"); // "jvm.dll" or "libjvm.so" or similar
769760
LOG("%s", output);
770-
771-
// Pointer into system library
772-
#ifndef _WIN32
773-
addr = CAST_FROM_FN_PTR(address, ::malloc);
774-
st.reset();
775-
EXPECT_TRUE(os::print_function_and_library_name(&st, addr,
776-
provide_scratch_buffer ? tmp : NULL,
777-
sizeof(tmp),
778-
shorten_paths, demangle));
779-
EXPECT_CONTAINS(output, "malloc");
780-
LINUX_ONLY(EXPECT_CONTAINS(output, "libc"));
781-
MACOS_ONLY(EXPECT_CONTAINS(output, "libsystem"));
782-
LOG("%s", output);
783-
#else
784-
addr = CAST_FROM_FN_PTR(address, CreateFileA);
785-
st.reset(); // this also zero-terminates start of output
786-
EXPECT_TRUE(os::print_function_and_library_name(&st, addr,
787-
provide_scratch_buffer ? tmp : NULL,
788-
sizeof(tmp),
789-
shorten_paths, demangle));
790-
for (char* p = output; *p; p++) {
791-
*p = ::toupper(*p);
792-
}
793-
EXPECT_CONTAINS(output, "KERNEL32.DLL");
794-
LOG("%s", output);
795-
#endif
796761
}
797762
}

0 commit comments

Comments
 (0)