Skip to content

Commit 8259044

Browse files
Matthew Donovanpull[bot]
authored andcommitted
8314283: Support for NSS tests on aarch64 platforms
Reviewed-by: rhalade
1 parent 1aa4df3 commit 8259044

File tree

2 files changed

+38
-17
lines changed

2 files changed

+38
-17
lines changed

test/jdk/sun/security/pkcs11/KeyStore/ClientAuth.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,10 @@ void startClient (boolean newThread) {
389389
* Our client thread just died.
390390
*/
391391
System.err.println("Client died...");
392+
// if the exception is thrown before connecting to the
393+
// server, the test will time out and the exception will
394+
// be lost/hidden.
395+
e.printStackTrace(System.err);
392396
clientException = e;
393397
}
394398
});

test/jdk/sun/security/pkcs11/PKCS11Test.java

Lines changed: 34 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,11 @@ public abstract class PKCS11Test {
7979
private static final char[] HEX_DIGITS = "0123456789abcdef".toCharArray();
8080
private static final SecureRandom srdm = new SecureRandom();
8181

82+
// Version of the NSS artifact. This coincides with the version of
83+
// the NSS version
84+
private static final String NSS_BUNDLE_VERSION = "3.91";
85+
private static final String NSSLIB = "jpg.tests.jdk.nsslib";
86+
8287
static double nss_version = -1;
8388
static ECCState nss_ecc_status = ECCState.Basic;
8489

@@ -807,18 +812,21 @@ static byte[] generateData(int length) {
807812

808813
private static String fetchNssLib(String osId) {
809814
switch (osId) {
810-
case "Windows-x86-32":
811-
return fetchNssLib(WINDOWS_X86.class);
812-
813815
case "Windows-amd64-64":
814816
return fetchNssLib(WINDOWS_X64.class);
815817

816818
case "MacOSX-x86_64-64":
817819
return fetchNssLib(MACOSX_X64.class);
818820

821+
case "MacOSX-aarch64-64":
822+
return fetchNssLib(MACOSX_AARCH64.class);
823+
819824
case "Linux-amd64-64":
820825
return fetchNssLib(LINUX_X64.class);
821826

827+
case "Linux-aarch64-64":
828+
return fetchNssLib(LINUX_AARCH64.class);
829+
822830
default:
823831
return null;
824832
}
@@ -828,8 +836,8 @@ private static String fetchNssLib(Class<?> clazz) {
828836
String path = null;
829837
try {
830838
path = ArtifactResolver.resolve(clazz).entrySet().stream()
831-
.findAny().get().getValue() + File.separator + "nsslib"
832-
+ File.separator;
839+
.findAny().get().getValue() + File.separator + "nss"
840+
+ File.separator + "lib" + File.separator;
833841
} catch (ArtifactResolverException e) {
834842
Throwable cause = e.getCause();
835843
if (cause == null) {
@@ -931,34 +939,43 @@ protected void copyNssCertKeyToClassesDir(Path dbPath) throws IOException {
931939
public static enum ECCState {None, Basic, Extended}
932940

933941
@Artifact(
934-
organization = "jpg.tests.jdk.nsslib",
942+
organization = NSSLIB,
935943
name = "nsslib-windows_x64",
936-
revision = "3.46-VS2017",
944+
revision = NSS_BUNDLE_VERSION,
937945
extension = "zip")
938946
private static class WINDOWS_X64 {
939947
}
940948

941949
@Artifact(
942-
organization = "jpg.tests.jdk.nsslib",
943-
name = "nsslib-windows_x86",
944-
revision = "3.46-VS2017",
950+
organization = NSSLIB,
951+
name = "nsslib-macosx_x64",
952+
revision = NSS_BUNDLE_VERSION,
945953
extension = "zip")
946-
private static class WINDOWS_X86 {
954+
private static class MACOSX_X64 {
947955
}
948956

949957
@Artifact(
950-
organization = "jpg.tests.jdk.nsslib",
951-
name = "nsslib-macosx_x64",
952-
revision = "3.46",
958+
organization = NSSLIB,
959+
name = "nsslib-macosx_aarch64",
960+
revision = NSS_BUNDLE_VERSION,
953961
extension = "zip")
954-
private static class MACOSX_X64 {
962+
private static class MACOSX_AARCH64 {
955963
}
956964

957965
@Artifact(
958-
organization = "jpg.tests.jdk.nsslib",
966+
organization = NSSLIB,
959967
name = "nsslib-linux_x64",
960-
revision = "3.46",
968+
revision = NSS_BUNDLE_VERSION,
961969
extension = "zip")
962970
private static class LINUX_X64 {
963971
}
972+
973+
@Artifact(
974+
organization = NSSLIB,
975+
name = "nsslib-linux_aarch64",
976+
revision = NSS_BUNDLE_VERSION,
977+
extension = "zip"
978+
)
979+
private static class LINUX_AARCH64{
980+
}
964981
}

0 commit comments

Comments
 (0)