Skip to content

Commit 6ac5e05

Browse files
committed
8302068: Serial: Refactor oop closures used in Young GC
Reviewed-by: tschatzl, iwalulya
1 parent 71cf7c4 commit 6ac5e05

File tree

12 files changed

+259
-340
lines changed

12 files changed

+259
-340
lines changed

src/hotspot/share/gc/serial/defNewGeneration.cpp

Lines changed: 253 additions & 86 deletions
Large diffs are not rendered by default.

src/hotspot/share/gc/serial/defNewGeneration.hpp

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939

4040
class ContiguousSpace;
4141
class CSpaceCounters;
42-
class DefNewYoungerGenClosure;
43-
class DefNewScanClosure;
42+
class OldGenScanClosure;
43+
class YoungGenScanClosure;
4444
class DefNewTracer;
4545
class ScanWeakRefClosure;
4646
class SerialHeap;
@@ -100,12 +100,6 @@ class DefNewGeneration: public Generation {
100100
// Preserved marks
101101
PreservedMarksSet _preserved_marks_set;
102102

103-
// Promotion failure handling
104-
OopIterateClosure *_promo_failure_scan_stack_closure;
105-
void set_promo_failure_scan_stack_closure(OopIterateClosure *scan_stack_closure) {
106-
_promo_failure_scan_stack_closure = scan_stack_closure;
107-
}
108-
109103
Stack<oop, mtGC> _promo_failure_scan_stack;
110104
void drain_promo_failure_scan_stack(void);
111105
bool _promo_failure_drain_in_progress;

src/hotspot/share/gc/serial/defNewGeneration.inline.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929

3030
#include "gc/shared/cardTableRS.hpp"
3131
#include "gc/shared/genCollectedHeap.hpp"
32-
#include "gc/shared/genOopClosures.inline.hpp"
3332
#include "gc/shared/space.inline.hpp"
3433
#include "oops/access.inline.hpp"
3534
#include "utilities/devirtualizer.inline.hpp"

src/hotspot/share/gc/serial/genMarkSweep.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,14 @@
3434
#include "compiler/oopMap.hpp"
3535
#include "gc/serial/genMarkSweep.hpp"
3636
#include "gc/serial/serialGcRefProcProxyTask.hpp"
37+
#include "gc/shared/cardTableRS.hpp"
3738
#include "gc/shared/collectedHeap.inline.hpp"
3839
#include "gc/shared/gcHeapSummary.hpp"
3940
#include "gc/shared/gcTimer.hpp"
4041
#include "gc/shared/gcTrace.hpp"
4142
#include "gc/shared/gcTraceTime.inline.hpp"
4243
#include "gc/shared/genCollectedHeap.hpp"
4344
#include "gc/shared/generation.hpp"
44-
#include "gc/shared/genOopClosures.inline.hpp"
4545
#include "gc/shared/modRefBarrierSet.hpp"
4646
#include "gc/shared/referencePolicy.hpp"
4747
#include "gc/shared/referenceProcessorPhaseTimes.hpp"

src/hotspot/share/gc/serial/serialHeap.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ GrowableArray<MemoryPool*> SerialHeap::memory_pools() {
9292
return memory_pools;
9393
}
9494

95-
void SerialHeap::young_process_roots(OopIterateClosure* root_closure,
95+
void SerialHeap::young_process_roots(OopClosure* root_closure,
9696
OopIterateClosure* old_gen_closure,
9797
CLDClosure* cld_closure) {
9898
MarkingCodeBlobClosure mark_code_closure(root_closure, CodeBlobToOopClosure::FixRelocations, false /* keepalive nmethods */);

src/hotspot/share/gc/serial/serialHeap.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ class SerialHeap : public GenCollectedHeap {
9797
void oop_since_save_marks_iterate(OopClosureType1* cur,
9898
OopClosureType2* older);
9999

100-
void young_process_roots(OopIterateClosure* root_closure,
100+
void young_process_roots(OopClosure* root_closure,
101101
OopIterateClosure* old_gen_closure,
102102
CLDClosure* cld_closure);
103103

src/hotspot/share/gc/serial/tenuredGeneration.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@
2626
#include "gc/serial/genMarkSweep.hpp"
2727
#include "gc/serial/serialBlockOffsetTable.inline.hpp"
2828
#include "gc/serial/tenuredGeneration.inline.hpp"
29+
#include "gc/shared/cardTableRS.hpp"
2930
#include "gc/shared/collectorCounters.hpp"
3031
#include "gc/shared/gcLocker.hpp"
3132
#include "gc/shared/gcTimer.hpp"
3233
#include "gc/shared/gcTrace.hpp"
3334
#include "gc/shared/genCollectedHeap.hpp"
3435
#include "gc/shared/generationSpec.hpp"
35-
#include "gc/shared/genOopClosures.inline.hpp"
3636
#include "gc/shared/space.hpp"
3737
#include "logging/log.hpp"
3838
#include "memory/allocation.inline.hpp"

src/hotspot/share/gc/shared/genCollectedHeap.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
#include "gc/shared/genArguments.hpp"
5050
#include "gc/shared/genCollectedHeap.hpp"
5151
#include "gc/shared/generationSpec.hpp"
52-
#include "gc/shared/genOopClosures.inline.hpp"
5352
#include "gc/shared/locationPrinter.inline.hpp"
5453
#include "gc/shared/oopStorage.inline.hpp"
5554
#include "gc/shared/oopStorageParState.inline.hpp"

src/hotspot/share/gc/shared/genOopClosures.hpp

Lines changed: 0 additions & 119 deletions
This file was deleted.

src/hotspot/share/gc/shared/genOopClosures.inline.hpp

Lines changed: 0 additions & 119 deletions
This file was deleted.

0 commit comments

Comments
 (0)