Skip to content

Commit 59ed1fa

Browse files
albluecl4es
authored andcommitted
8264087: Use the blessed modifier order in jdk.jconsole
Reviewed-by: alanb, amenkov, redestad
1 parent 054e0a4 commit 59ed1fa

File tree

11 files changed

+31
-31
lines changed

11 files changed

+31
-31
lines changed

src/jdk.jconsole/share/classes/sun/tools/jconsole/Formatter.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,17 @@
3030

3131

3232
class Formatter {
33-
final static long SECOND = 1000;
34-
final static long MINUTE = 60 * SECOND;
35-
final static long HOUR = 60 * MINUTE;
36-
final static long DAY = 24 * HOUR;
33+
static final long SECOND = 1000;
34+
static final long MINUTE = 60 * SECOND;
35+
static final long HOUR = 60 * MINUTE;
36+
static final long DAY = 24 * HOUR;
3737

38-
final static String cr = System.getProperty("line.separator");
38+
static final String cr = System.getProperty("line.separator");
3939

40-
final static DateFormat timeDF = new SimpleDateFormat("HH:mm");
41-
private final static DateFormat timeWithSecondsDF = new SimpleDateFormat("HH:mm:ss");
42-
private final static DateFormat dateDF = new SimpleDateFormat("yyyy-MM-dd");
43-
private final static String decimalZero =
40+
static final DateFormat timeDF = new SimpleDateFormat("HH:mm");
41+
private static final DateFormat timeWithSecondsDF = new SimpleDateFormat("HH:mm:ss");
42+
private static final DateFormat dateDF = new SimpleDateFormat("yyyy-MM-dd");
43+
private static final String decimalZero =
4444
new DecimalFormatSymbols().getDecimalSeparator() + "0";
4545

4646
static String formatTime(long t) {

src/jdk.jconsole/share/classes/sun/tools/jconsole/JConsole.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ static void updateLafValues() {
8282
}
8383

8484

85-
private final static String title =
85+
private static final String title =
8686
Messages.JAVA_MONITORING___MANAGEMENT_CONSOLE;
87-
public final static String ROOT_URL =
87+
public static final String ROOT_URL =
8888
"service:jmx:";
8989

9090
private static int updateInterval = 4000;

src/jdk.jconsole/share/classes/sun/tools/jconsole/Messages.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
* Class that contains localized messages.
3030
*
3131
*/
32-
final public class Messages {
32+
public final class Messages {
3333
private static final String BUNDLE_NAME = "sun.tools.jconsole.resources.messages";
3434

3535
static {

src/jdk.jconsole/share/classes/sun/tools/jconsole/Plotter.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,15 +91,15 @@ public static enum Unit {
9191
};
9292

9393

94-
final static long SECOND = 1000;
95-
final static long MINUTE = 60 * SECOND;
96-
final static long HOUR = 60 * MINUTE;
97-
final static long DAY = 24 * HOUR;
94+
static final long SECOND = 1000;
95+
static final long MINUTE = 60 * SECOND;
96+
static final long HOUR = 60 * MINUTE;
97+
static final long DAY = 24 * HOUR;
9898

99-
final static Color bgColor = new Color(250, 250, 250);
100-
final static Color defaultColor = Color.blue.darker();
99+
static final Color bgColor = new Color(250, 250, 250);
100+
static final Color defaultColor = Color.blue.darker();
101101

102-
final static int ARRAY_SIZE_INCREMENT = 4000;
102+
static final int ARRAY_SIZE_INCREMENT = 4000;
103103

104104
private static Stroke dashedStroke;
105105

src/jdk.jconsole/share/classes/sun/tools/jconsole/ProxyClient.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,8 @@ public class ProxyClient implements JConsoleContext {
8787
private boolean vmConnector = false;
8888
private boolean sslRegistry = false;
8989
private boolean sslStub = false;
90-
final private String connectionName;
91-
final private String displayName;
90+
private final String connectionName;
91+
private final String displayName;
9292

9393
private ClassLoadingMXBean classLoadingMBean = null;
9494
private CompilationMXBean compilationMBean = null;
@@ -103,7 +103,7 @@ public class ProxyClient implements JConsoleContext {
103103
private List<MemoryPoolProxy> memoryPoolProxies = null;
104104
private List<GarbageCollectorMXBean> garbageCollectorMBeans = null;
105105

106-
final static private String HOTSPOT_DIAGNOSTIC_MXBEAN_NAME =
106+
private static final String HOTSPOT_DIAGNOSTIC_MXBEAN_NAME =
107107
"com.sun.management:type=HotSpotDiagnostic";
108108

109109
private ProxyClient(String hostName, int port,

src/jdk.jconsole/share/classes/sun/tools/jconsole/Resources.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public static int getMnemonicInt(String message) {
7474
}
7575

7676
/**
77-
* Initializes all non-final public static fields in the given class with
77+
* Initializes all public static non-final fields in the given class with
7878
* messages from a {@link ResourceBundle}.
7979
*
8080
* @param clazz the class containing the fields

src/jdk.jconsole/share/classes/sun/tools/jconsole/inspector/XMBeanAttributes.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public class XMBeanAttributes extends XTable {
8383
final Logger LOGGER =
8484
System.getLogger(XMBeanAttributes.class.getPackage().getName());
8585

86-
private final static String[] columnNames =
86+
private static final String[] columnNames =
8787
{Messages.NAME,
8888
Messages.VALUE};
8989

src/jdk.jconsole/share/classes/sun/tools/jconsole/inspector/XMBeanNotifications.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
@SuppressWarnings("serial")
5151
public class XMBeanNotifications extends JTable implements NotificationListener {
5252

53-
private final static String[] columnNames = {
53+
private static final String[] columnNames = {
5454
Messages.TIME_STAMP,
5555
Messages.TYPE,
5656
Messages.USER_DATA,
@@ -63,7 +63,7 @@ public class XMBeanNotifications extends JTable implements NotificationListener
6363
new HashMap<ObjectName, XMBeanNotificationsListener>();
6464
private volatile boolean subscribed;
6565
private XMBeanNotificationsListener currentListener;
66-
public final static String NOTIFICATION_RECEIVED_EVENT =
66+
public static final String NOTIFICATION_RECEIVED_EVENT =
6767
"jconsole.xnotification.received";
6868
private List<NotificationListener> notificationListenersList;
6969
private volatile boolean enabled;

src/jdk.jconsole/share/classes/sun/tools/jconsole/inspector/XObject.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
public class XObject extends JLabel {
3838
private Object object;
3939
private static boolean useHashCodeRepresentation = true;
40-
public final static XObject NULL_OBJECT = new XObject("null");
40+
public static final XObject NULL_OBJECT = new XObject("null");
4141
public XObject (Object object, Icon icon) {
4242
this(object);
4343
setIcon(icon);

src/jdk.jconsole/share/classes/sun/tools/jconsole/inspector/XOperations.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
@SuppressWarnings("serial") // JDK implementation class
4343
public abstract class XOperations extends JPanel implements ActionListener {
4444

45-
public final static String OPERATION_INVOCATION_EVENT =
45+
public static final String OPERATION_INVOCATION_EVENT =
4646
"jam.xoperations.invoke.result";
4747
private java.util.List<NotificationListener> notificationListenersList;
4848
private Hashtable<JButton, OperationEntry> operationEntryTable;

0 commit comments

Comments
 (0)