David's feedback

Author: gerard-ziemski

src/hotspot/os/aix/os_aix.cpp

@@ -1439,10 +1439,6 @@ void os::pd_print_cpu_info(outputStream* st, char* buf, size_t buflen) {
   // Nothing to do beyond of what os::print_cpu_info() does.
 }
 
-void os::print_signal_handlers(outputStream* st, char* buf, size_t buflen) {
-  PosixSignals::print_signal_handlers(st, buf, buflen);
-}
-
 static char saved_jvm_path[MAXPATHLEN] = {0};
 
 // Find the full path to the current module, libjvm.so.
@@ -2575,10 +2571,6 @@ bool os::bind_to_processor(uint processor_id) {
   return false;
 }
 
-void os::SuspendedThreadTask::internal_do_task() {
-  PosixSignals::do_task(_thread, this);
-}
-
 ////////////////////////////////////////////////////////////////////////////////
 // debug support
 

src/hotspot/os/bsd/os_bsd.cpp

@@ -1539,10 +1539,6 @@ void os::print_memory_info(outputStream* st) {
   st->cr();
 }
 
-void os::print_signal_handlers(outputStream* st, char* buf, size_t buflen) {
-  PosixSignals::print_signal_handlers(st, buf, buflen);
-}
-
 static char saved_jvm_path[MAXPATHLEN] = {0};
 
 // Find the full path to the current module, libjvm
@@ -2261,10 +2257,6 @@ bool os::bind_to_processor(uint processor_id) {
   return false;
 }
 
-void os::SuspendedThreadTask::internal_do_task() {
-  PosixSignals::do_task(_thread, this);
-}
-
 ////////////////////////////////////////////////////////////////////////////////
 // debug support
 

src/hotspot/os/linux/os_linux.cpp

@@ -2600,10 +2600,6 @@ void os::get_summary_cpu_info(char* cpuinfo, size_t length) {
 #endif
 }
 
-void os::print_signal_handlers(outputStream* st, char* buf, size_t buflen) {
-  PosixSignals::print_signal_handlers(st, buf, buflen);
-}
-
 static char saved_jvm_path[MAXPATHLEN] = {0};
 
 // Find the full path to the current module, libjvm.so
@@ -4681,12 +4677,6 @@ bool os::bind_to_processor(uint processor_id) {
   return false;
 }
 
-///
-
-void os::SuspendedThreadTask::internal_do_task() {
-  PosixSignals::do_task(_thread, this);
-}
-
 ////////////////////////////////////////////////////////////////////////////////
 // debug support
 

src/hotspot/os/posix/signals_posix.cpp

@@ -1281,7 +1281,7 @@ void PosixSignals::print_signal_handler(outputStream* st, int sig,
   st->cr();
 }
 
-void PosixSignals::print_signal_handlers(outputStream* st, char* buf, size_t buflen) {
+void os::print_signal_handlers(outputStream* st, char* buf, size_t buflen) {
   st->print_cr("Signal Handlers:");
   PosixSignals::print_signal_handler(st, SIGSEGV, buf, buflen);
   PosixSignals::print_signal_handler(st, SIGBUS , buf, buflen);
@@ -1638,11 +1638,11 @@ void PosixSignals::do_resume(OSThread* osthread) {
   guarantee(osthread->sr.is_running(), "Must be running!");
 }
 
-void PosixSignals::do_task(Thread* thread, os::SuspendedThreadTask* task) {
-  if (PosixSignals::do_suspend(thread->osthread())) {
-    os::SuspendedThreadTaskContext context(thread, thread->osthread()->ucontext());
-    task->do_task(context);
-    PosixSignals::do_resume(thread->osthread());
+void os::SuspendedThreadTask::internal_do_task() {
+  if (PosixSignals::do_suspend(_thread->osthread())) {
+    os::SuspendedThreadTaskContext context(_thread, _thread->osthread()->ucontext());
+    do_task(context);
+    PosixSignals::do_resume(_thread->osthread());
   }
 }
 

src/hotspot/os/posix/signals_posix.hpp

@@ -35,7 +35,6 @@ typedef sigset_t sigset_t;
 class outputStream;
 class Thread;
 class OSThread;
-class SuspendedThreadTask;
 
 class PosixSignals : public AllStatic {
 
@@ -55,12 +54,10 @@ class PosixSignals : public AllStatic {
   static void hotspot_sigmask(Thread* thread);
 
   static void print_signal_handler(outputStream* st, int sig, char* buf, size_t buflen);
-  static void print_signal_handlers(outputStream* st, char* buf, size_t buflen);
 
   // Suspend-resume
   static bool do_suspend(OSThread* osthread);
   static void do_resume(OSThread* osthread);
-  static void do_task(Thread* thread, os::SuspendedThreadTask* task);
 
   // For signal-chaining
   static bool chained_handler(int sig, siginfo_t* siginfo, void* context);

src/hotspot/os/windows/os_windows.cpp

@@ -1872,10 +1872,6 @@ bool os::signal_thread(Thread* thread, int sig, const char* reason) {
   return false;
 }
 
-void os::print_signal_handlers(outputStream* st, char* buf, size_t buflen) {
-  // do nothing
-}
-
 static char saved_jvm_path[MAX_PATH] = {0};
 
 // Find the full path to the current module, jvm.dll