Skip to content

Commit 4a242e3

Browse files
committed
8354213: Restore pointless unicode characters to ASCII
Reviewed-by: naoto, erikj, iris
1 parent 776e1cf commit 4a242e3

File tree

22 files changed

+45
-45
lines changed

22 files changed

+45
-45
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# Contributing to the JDK
22

3-
Please see the [OpenJDK Developers Guide](https://openjdk.org/guide/).
3+
Please see the [OpenJDK Developers' Guide](https://openjdk.org/guide/).

doc/hotspot-unit-tests.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ Prefer having checks inside test code.
106106

107107
Not only does having test logic outside, e.g. verification method,
108108
depending on asserts in product code contradict with several items
109-
above but also decreases tests readability and stability. It is much
109+
above but also decreases test's readability and stability. It is much
110110
easier to understand that a test is testing when all testing logic is
111111
located inside a test or nearby in shared test libraries. As a rule of
112112
thumb, the closer a check to a test, the better.
@@ -119,7 +119,7 @@ Prefer `EXPECT` over `ASSERT` if possible.
119119

120120
This is related to the [informativeness](#informativeness) property of
121121
tests, information for other checks can help to better localize a
122-
defects root-cause. One should use `ASSERT` if it is impossible to
122+
defect's root-cause. One should use `ASSERT` if it is impossible to
123123
continue test execution or if it does not make much sense. Later in
124124
the text, `EXPECT` forms will be used to refer to both
125125
`ASSERT/EXPECT`.
@@ -160,7 +160,7 @@ value of the difference between `v1` and `v2` is not greater than `eps`.
160160

161161
Use string special macros for C strings comparisons.
162162

163-
`EXPECT_EQ` just compares pointers values, which is hardly what one
163+
`EXPECT_EQ` just compares pointers' values, which is hardly what one
164164
wants comparing C strings. GoogleTest provides `EXPECT_STREQ` and
165165
`EXPECT_STRNE` macros to compare C string contents. There are also
166166
case-insensitive versions `EXPECT_STRCASEEQ`, `EXPECT_STRCASENE`.
@@ -226,7 +226,7 @@ subsystem, etc.
226226

227227
This naming scheme helps to find tests, filter them and simplifies
228228
test failure analysis. For example, class `Foo` - test group `Foo`,
229-
compiler logging subsystem - test group `CompilerLogging`, G1 GC test
229+
compiler logging subsystem - test group `CompilerLogging`, G1 GC - test
230230
group `G1GC`, and so forth.
231231

232232
### Filename
@@ -287,7 +287,7 @@ Fixture classes should be named after tested classes, subsystems, etc
287287

288288
All test purpose friends should have either `Test` or `Testable` suffix.
289289

290-
It greatly simplifies understanding of friendships purpose and allows
290+
It greatly simplifies understanding of friendship's purpose and allows
291291
statically check that private members are not exposed unexpectedly.
292292
Having `FooTest` as a friend of `Foo` without any comments will be
293293
understood as a necessary evil to get testability.
@@ -397,7 +397,7 @@ and filter out inapplicable tests.
397397
Restore changed flags.
398398

399399
It is quite common for tests to configure JVM in a certain way
400-
changing flags values. GoogleTest provides two ways to set up
400+
changing flags' values. GoogleTest provides two ways to set up
401401
environment before a test and restore it afterward: using either
402402
constructor and destructor or `SetUp` and `TearDown` functions. Both ways
403403
require to use a test fixture class, which sometimes is too wordy. The
@@ -406,7 +406,7 @@ be used in such cases to restore/set values.
406406

407407
Caveats:
408408

409-
* Changing a flags value could break the invariants between flags' values and hence could lead to unexpected/unsupported JVM state.
409+
* Changing a flag's value could break the invariants between flags' values and hence could lead to unexpected/unsupported JVM state.
410410

411411
* `FLAG_SET_*` macros can change more than one flag (in order to
412412
maintain invariants) so it is hard to predict what flags will be

src/hotspot/cpu/riscv/c1_CodeStubs_riscv.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ void RangeCheckStub::emit_code(LIR_Assembler* ce) {
8787
__ mv(t1, _array->as_pointer_register());
8888
stub_id = C1StubId::throw_range_check_failed_id;
8989
}
90-
// t0 and t1 are used as args in generate_exception_throw
90+
// t0 and t1 are used as args in generate_exception_throw,
9191
// so use x1/ra as the tmp register for rt_call.
9292
__ rt_call(Runtime1::entry_for(stub_id), ra);
9393
ce->add_call_info_here(_info);

src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ void BarrierSetAssembler::nmethod_entry_barrier(MacroAssembler* masm, Label* slo
275275
// order, while allowing other independent instructions to be reordered.
276276
// Note: This may be slower than using a membar(load|load) (fence r,r).
277277
// Because processors will not start the second load until the first comes back.
278-
// This means you cant overlap the two loads,
278+
// This means you can't overlap the two loads,
279279
// which is stronger than needed for ordering (stronger than TSO).
280280
__ srli(ra, t0, 32);
281281
__ orr(t1, t1, ra);

src/hotspot/cpu/riscv/macroAssembler_riscv.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -670,9 +670,9 @@ class MacroAssembler: public Assembler {
670670
// JALR, return address stack updates:
671671
// | rd is x1/x5 | rs1 is x1/x5 | rd=rs1 | RAS action
672672
// | ----------- | ------------ | ------ |-------------
673-
// | No | No | | None
674-
// | No | Yes | | Pop
675-
// | Yes | No | | Push
673+
// | No | No | - | None
674+
// | No | Yes | - | Pop
675+
// | Yes | No | - | Push
676676
// | Yes | Yes | No | Pop, then push
677677
// | Yes | Yes | Yes | Push
678678
//

src/hotspot/cpu/s390/disassembler_s390.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ address Disassembler::decode_instruction0(address here, outputStream * st, addre
6262

6363
if (Assembler::is_z_nop((long)instruction_2bytes)) {
6464
#if 1
65-
st->print("nop "); // fill up to operand column, leads to better code comment alignment
65+
st->print("nop "); // fill up to operand column, leads to better code comment alignment
6666
next = here + 2;
6767
#else
6868
// Compact disassembler output. Does not work the easy way.
@@ -76,7 +76,7 @@ address Disassembler::decode_instruction0(address here, outputStream * st, addre
7676
instruction_2bytes = *(uint16_t*)(here+2*n_nops);
7777
}
7878
if (n_nops <= 4) { // do not group few subsequent nops
79-
st->print("nop "); // fill up to operand column, leads to better code comment alignment
79+
st->print("nop "); // fill up to operand column, leads to better code comment alignment
8080
next = here + 2;
8181
} else {
8282
st->print("nop count=%d", n_nops);

src/hotspot/cpu/s390/s390.ad

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6581,7 +6581,7 @@ instruct mulHiL_reg_reg(revenRegL Rdst, roddRegL Rsrc1, iRegL Rsrc2, iRegL Rtmp1
65816581
Register tmp1 = $Rtmp1$$Register;
65826582
Register tmp2 = $Rdst$$Register;
65836583
// z/Architecture has only unsigned multiply (64 * 64 -> 128).
6584-
// implementing mulhs(a,b) = mulhu(a,b) (a & (b>>63)) (b & (a>>63))
6584+
// implementing mulhs(a,b) = mulhu(a,b) - (a & (b>>63)) - (b & (a>>63))
65856585
__ z_srag(tmp2, src1, 63); // a>>63
65866586
__ z_srag(tmp1, src2, 63); // b>>63
65876587
__ z_ngr(tmp2, src2); // b & (a>>63)

src/hotspot/os/aix/libperfstat_aix.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ typedef struct { /* component perfstat_cpu_t from AIX 7.2 documentation */
332332
u_longlong_t busy_stolen_purr; /* Number of busy cycles stolen by the hypervisor from a dedicated partition. */
333333
u_longlong_t busy_stolen_spurr; /* Number of busy spurr cycles stolen by the hypervisor from a dedicated partition.*/
334334
u_longlong_t shcpus_in_sys; /* Number of physical processors allocated for shared processor use, across all shared processors pools. */
335-
u_longlong_t entitled_pool_capacity; /* Entitled processor capacity of partitions pool. */
335+
u_longlong_t entitled_pool_capacity; /* Entitled processor capacity of partition's pool. */
336336
u_longlong_t pool_max_time; /* Summation of maximum time that can be consumed by the pool (nanoseconds). */
337337
u_longlong_t pool_busy_time; /* Summation of busy (nonidle) time accumulated across all partitions in the pool (nanoseconds). */
338338
u_longlong_t pool_scaled_busy_time; /* Scaled summation of busy (nonidle) time accumulated across all partitions in the pool (nanoseconds). */

src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ DECLARE_FUNC(aarch64_atomic_cmpxchg_8_relaxed_default_impl):
295295
ret
296296

297297
/* Emit .note.gnu.property section in case of PAC or BTI being enabled.
298-
* For more details see "ELF for the Arm® 64-bit Architecture (AArch64)".
298+
* For more details see "ELF for the Arm(R) 64-bit Architecture (AArch64)".
299299
* https://github.com/ARM-software/abi-aa/blob/main/aaelf64/aaelf64.rst
300300
*/
301301
#ifdef __ARM_FEATURE_BTI_DEFAULT

src/hotspot/os_cpu/linux_aarch64/copy_linux_aarch64.S

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ bwd_copy_drain:
269269
ret
270270

271271
/* Emit .note.gnu.property section in case of PAC or BTI being enabled.
272-
* For more details see "ELF for the Arm® 64-bit Architecture (AArch64)".
272+
* For more details see "ELF for the Arm(R) 64-bit Architecture (AArch64)".
273273
* https://github.com/ARM-software/abi-aa/blob/main/aaelf64/aaelf64.rst
274274
*/
275275
#ifdef __ARM_FEATURE_BTI_DEFAULT

0 commit comments

Comments
 (0)