8356233: NMT: tty->print_cr should not be used in VirtualMemoryTracker::add_reserved_region()

Reviewed-by: jsjolen, dholmes

Author: Gerard Ziemski

src/hotspot/share/nmt/virtualMemoryTracker.cpp

@@ -401,17 +401,20 @@ bool VirtualMemoryTracker::add_reserved_region(address base_addr, size_t size,
         return true;
       }
 
-      // Print some more details. Don't use UL here to avoid circularities.
-      tty->print_cr("Error: existing region: [" INTPTR_FORMAT "-" INTPTR_FORMAT "), memory tag %u.\n"
-                    "       new region: [" INTPTR_FORMAT "-" INTPTR_FORMAT "), memory tag %u.",
-                    p2i(reserved_rgn->base()), p2i(reserved_rgn->end()), (unsigned)reserved_rgn->mem_tag(),
-                    p2i(base_addr), p2i(base_addr + size), (unsigned)mem_tag);
+      // Print some more details.
+      stringStream ss;
+      ss.print_cr("Error: old region: [" INTPTR_FORMAT "-" INTPTR_FORMAT "), memory tag %s.\n"
+                    "       new region: [" INTPTR_FORMAT "-" INTPTR_FORMAT "), memory tag %s.",
+                    p2i(reserved_rgn->base()), p2i(reserved_rgn->end()), NMTUtil::tag_to_name(reserved_rgn->mem_tag()),
+                    p2i(base_addr), p2i(base_addr + size), NMTUtil::tag_to_name(mem_tag));
       if (MemTracker::tracking_level() == NMT_detail) {
-        tty->print_cr("Existing region allocated from:");
-        reserved_rgn->call_stack()->print_on(tty);
-        tty->print_cr("New region allocated from:");
-        stack.print_on(tty);
+        ss.print_cr("Existing region allocated from:");
+        reserved_rgn->call_stack()->print_on(&ss);
+        ss.print_cr("New region allocated from:");
+        stack.print_on(&ss);
       }
+      log_debug(nmt)("%s", ss.freeze());
+
       ShouldNotReachHere();
       return false;
     }