8287602: (fs) Avoid redundant HashMap.containsKey call in MimeTypesFileTypeDetector.putIfAbsent

Andrey Turbanov · Andrey Turbanov · commit 27ad1d5549eb · 2022-06-01T18:14:25.000Z
Reviewed-by: bpb, jpai, alanb
diff --git a/src/java.base/unix/classes/sun/nio/fs/MimeTypesFileTypeDetector.java b/src/java.base/unix/classes/sun/nio/fs/MimeTypesFileTypeDetector.java
@@ -187,11 +187,8 @@ private void parseMimeEntry(String entry) {
     }
 
     private void putIfAbsent(String key, String value) {
-        if (key != null && !key.isEmpty() &&
-            value != null && !value.isEmpty() &&
-            !mimeTypeMap.containsKey(key))
-        {
-            mimeTypeMap.put(key, value);
+        if (!key.isEmpty() && !value.isEmpty()) {
+            mimeTypeMap.putIfAbsent(key, value);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -187,11 +187,8 @@ private void parseMimeEntry(String entry) {`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`private void putIfAbsent(String key, String value) {`
`190`		`- if (key != null && !key.isEmpty() &&`
`191`		`- value != null && !value.isEmpty() &&`
`192`		`- !mimeTypeMap.containsKey(key))`
`193`		`- {`
`194`		`- mimeTypeMap.put(key, value);`
	`190`	`+ if (!key.isEmpty() && !value.isEmpty()) {`
	`191`	`+ mimeTypeMap.putIfAbsent(key, value);`
`195`	`192`	`}`
`196`	`193`	`}`
`197`	`194`	`}`