Skip to content

Commit 0ef3d85

Browse files
feilongjiangDingliZhang
authored andcommitted
8287552: riscv: Fix comment typo in li64
Co-authored-by: Dingli Zhang <[email protected]> Reviewed-by: fyang
1 parent e0e15de commit 0ef3d85

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/hotspot/cpu/riscv/assembler_riscv.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ void Assembler::_li(Register Rd, int64_t imm) {
118118

119119
void Assembler::li64(Register Rd, int64_t imm) {
120120
// Load upper 32 bits. upper = imm[63:32], but if imm[31] == 1 or
121-
// (imm[31:28] == 0x7ff && imm[19] == 1), upper = imm[63:32] + 1.
121+
// (imm[31:20] == 0x7ff && imm[19] == 1), upper = imm[63:32] + 1.
122122
int64_t lower = imm & 0xffffffff;
123123
lower -= ((lower << 44) >> 44);
124124
int64_t tmp_imm = ((uint64_t)(imm & 0xffffffff00000000)) + (uint64_t)lower;
@@ -273,18 +273,18 @@ void Assembler::wrap_label(Register Rt, Label &L, jal_jalr_insn insn) {
273273
}
274274

275275
void Assembler::movptr_with_offset(Register Rd, address addr, int32_t &offset) {
276-
uintptr_t imm64 = (uintptr_t)addr;
276+
int64_t imm64 = (int64_t)addr;
277277
#ifndef PRODUCT
278278
{
279279
char buffer[64];
280280
snprintf(buffer, sizeof(buffer), "0x%" PRIx64, imm64);
281281
block_comment(buffer);
282282
}
283283
#endif
284-
assert(is_unsigned_imm_in_range(imm64, 47, 0) || (imm64 == (uintptr_t)-1),
284+
assert(is_unsigned_imm_in_range(imm64, 47, 0) || (imm64 == (int64_t)-1),
285285
"bit 47 overflows in address constant");
286286
// Load upper 31 bits
287-
int32_t imm = imm64 >> 17;
287+
int64_t imm = imm64 >> 17;
288288
int64_t upper = imm, lower = imm;
289289
lower = (lower << 52) >> 52;
290290
upper -= lower;

src/hotspot/cpu/riscv/macroAssembler_riscv.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1200,7 +1200,7 @@ static int patch_imm_in_li64(address branch, address target) {
12001200
tmp_lower = (tmp_lower << 52) >> 52;
12011201
tmp_upper -= tmp_lower;
12021202
tmp_upper >>= 12;
1203-
// Load upper 32 bits. Upper = target[63:32], but if target[31] = 1 or (target[31:28] == 0x7ff && target[19] == 1),
1203+
// Load upper 32 bits. Upper = target[63:32], but if target[31] = 1 or (target[31:20] == 0x7ff && target[19] == 1),
12041204
// upper = target[63:32] + 1.
12051205
Assembler::patch(branch + 0, 31, 12, tmp_upper & 0xfffff); // Lui.
12061206
Assembler::patch(branch + 4, 31, 20, tmp_lower & 0xfff); // Addi.

0 commit comments

Comments
 (0)