Skip to content

Remove map from data initialization so it is available but not reactive #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove map from data initialization so it is available but not reactive #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12b2ee4
Remove map from data initialization so it is available but not reactive
bob-voorhoede Jul 31, 2020
0debcf2
Merge branch 'master' into feat/remove-reactivity-from-map-object
Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/components/VMapbox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,14 +144,6 @@ export const props = {

export default {
name: 'v-mapbox',

// @QUESTION :: Why is this back? Now the whole map is reactive again..
data () {
Copy link
Collaborator

@SiggyF SiggyF Aug 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed this before, but this caused several issues. Please consult with Cindy. If you don't initialize it from the data section it should be set on the object.
You can try to set it as a "normal" property of the object. Then you can access it through $options, see [1]. We also tried this before but this also gave synchronisation issues.

[1] https://vuejs.org/v2/api/#vm-options

return {
map: null
}
},

props,

provide () {
Expand Down