Remove map from data initialization so it is available but not reactive #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiggyF
reviewed
Aug 17, 2020
Collaborator
SiggyF
left a comment
SiggyF
left a comment
There was a problem hiding this comment.
Please keep map as a non reactive attribute. It is now set just before created by the data() function. In this new approach the map is set during mounted and not available earlier.
| export default { | ||
| name: 'v-mapbox', | ||
| data () { |
Collaborator
There was a problem hiding this comment.
We removed this before, but this caused several issues. Please consult with Cindy. If you don't initialize it from the data section it should be set on the object.
You can try to set it as a "normal" property of the object. Then you can access it through $options, see [1]. We also tried this before but this also gave synchronisation issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For performance reasons it is desirable to not have a gigantic reactive map object. when that's unnecessary.
By not declaring it in
datainitialization, but still tacking it on thethisin the component, we can use it in JS and pass it along to child components, but without it being augmented by Vue's reactivity system.