Skip to content

Conversation

@AleksandrPanov
Copy link
Contributor

@AleksandrPanov AleksandrPanov commented Nov 11, 2021

@alalek
Copy link
Member

alalek commented Nov 18, 2021

Why do we need new images to test returned types? Why old images does not work?

@AleksandrPanov
Copy link
Contributor Author

Why do we need new images to test returned types? Why old images does not work?

There is some "if" in void refineDetectedMarkers:

    // parse output
    if(finalAcceptedIds.size() != _detectedIds.total()) {

This condition is met only one image (recover.png).

@AleksandrPanov AleksandrPanov marked this pull request as draft November 29, 2021 16:57
@AleksandrPanov AleksandrPanov force-pushed the fix_refineDetectedMarkers_shape branch from 4f4aa66 to 998b7d0 Compare February 1, 2022 15:33
@AleksandrPanov AleksandrPanov force-pushed the fix_refineDetectedMarkers_shape branch from 998b7d0 to 9b26be8 Compare February 1, 2022 15:35
@AleksandrPanov AleksandrPanov marked this pull request as ready for review February 7, 2022 11:36
@AleksandrPanov
Copy link
Contributor Author

AleksandrPanov commented Feb 7, 2022

Why do we need new images to test returned types? Why old images does not work?

@alalek, current tests show no errors because they use vector<vector<Point2f> > for corners and rejectedCorners. Also, the current tests only check the number of refined corners (dimension and value are not checked).

@AleksandrPanov AleksandrPanov removed their assignment Feb 9, 2022
@opencv-pushbot opencv-pushbot merged commit e2dc7f6 into opencv:3.4 Feb 9, 2022
@alalek alalek mentioned this pull request Feb 10, 2022
@alalek alalek mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants