-
Notifications
You must be signed in to change notification settings - Fork 5.9k
make opencv_cudaarithm dependency for xfeatures2d optional #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the update, it was indeed necessary. However on windows and linux builds this change breaks java wrapper wich seems weird to me. Any clue on how this can happen? |
|
This is the original commit that made this change: |
|
Maybe suggest to disable java bindings for xfeatures 2d module until solutions drop out of the box? Ths can be done here:https://github.com/Itseez/opencv/blob/master/modules/java/CMakeLists.txt#L11 @vpisarev what do you think? |
|
Let me re-run the builds, it may be an external problem |
|
👍 |
|
I suggest we disable java bindings for xfeatures2d module |
|
@mshabunin, reassigning this to you. Hopefully, you could help to resolve this confusing dependency problems |
|
All builds are passing now. |
|
@mshabunin , then you may 👍 it! |
|
👍 |
|
Come on, let's merge it already :) |
|
It can take some time :) Just be patient :P |
make opencv_cudaarithm dependency for xfeatures2d optional
* Add body index map image publishing * Change body index map image to mono8 format * Fixed small syntax error * Added topic description in usage.md * Fixed typos in usage.md
No description provided.