Skip to content

Conversation

@cudawarped
Copy link
Contributor

@cudawarped cudawarped commented Apr 19, 2023

Modified histogram kernels to work with non aligned data to fix #3473.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@cudawarped cudawarped changed the title cuda: fix https://github.com/opencv/opencv_contrib/issues/3473 cuda: fix 3473 Apr 19, 2023
@cudawarped cudawarped force-pushed the cuda_fix_unaligned_hist branch from 14a56cc to fc9f461 Compare April 19, 2023 13:55
@asmorkalov asmorkalov self-requested a review April 20, 2023 14:31
@cudawarped cudawarped force-pushed the cuda_fix_unaligned_hist branch from fc9f461 to 10e29b2 Compare June 16, 2023 12:41
@asmorkalov asmorkalov changed the title cuda: fix 3473 Modified histogram kernels to work with non aligned data Jun 27, 2023
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Tested manually, including performance changes with CUDA 10.2, GF 1080.

@asmorkalov asmorkalov merged commit 4f66f86 into opencv:4.x Jun 27, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cuda::calcHist only works when source data is 4 byte aligned

2 participants