Skip to content

Update find ellipses #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2022
Merged

Update find ellipses #3369

merged 1 commit into from
Dec 19, 2022

Conversation

@sturkmen72
Copy link
Contributor

@sturkmen72 sturkmen72 commented Oct 26, 2022

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@sturkmen72 sturkmen72 marked this pull request as draft October 26, 2022 15:32
@sturkmen72
Copy link
Contributor Author

sturkmen72 commented Oct 26, 2022

/cc @MisakiCoca

@asmorkalov
Copy link
Contributor

asmorkalov commented Dec 15, 2022

@sturkmen72 Is the patch ready for review?

@sturkmen72 sturkmen72 force-pushed the update_find_ellipses branch 2 times, most recently from 81c33d4 to 59b82a3 Compare December 15, 2022 16:18
@sturkmen72 sturkmen72 marked this pull request as ready for review December 15, 2022 16:19
@sturkmen72
Copy link
Contributor Author

sturkmen72 commented Dec 15, 2022

@asmorkalov the patch is ready for review except "trailing whitespace" issue ( I did not understand what is the problem )

alalek
alalek reviewed Dec 18, 2022
View reviewed changes
alalek
alalek approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for contribution!

@asmorkalov asmorkalov merged commit b5f4e24 into opencv:4.x Dec 19, 2022
@sturkmen72 sturkmen72 deleted the update_find_ellipses branch December 19, 2022 13:07
@alalek alalek mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

No one assigned

Labels

category: samples category: ximgproc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sturkmen72 @asmorkalov @alalek