Skip to content

Remove unused size of get_subbox_chart_physical() #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Remove unused size of get_subbox_chart_physical() #3321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions modules/mcc/src/checker_detector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,8 +802,7 @@ void CCheckerDetectorImpl::

// get physical char box model
std::vector<cv::Point2f> chartPhy;
cv::Size size_box_phy;
get_subbox_chart_physical(points, chartPhy, size_box_phy);
get_subbox_chart_physical(points, chartPhy);

// Find the perspective transformation that brings current chart to rectangular form
Matx33f ccT = cv::getPerspectiveTransform(points, chartPhy);
Expand Down Expand Up @@ -1101,7 +1100,7 @@ void CCheckerDetectorImpl::
}

void CCheckerDetectorImpl::
get_subbox_chart_physical(const std::vector<cv::Point2f> &points, std::vector<cv::Point2f> &chartPhy, cv::Size &size)
get_subbox_chart_physical(const std::vector<cv::Point2f> &points, std::vector<cv::Point2f> &chartPhy)
{
float w, h;
cv::Point2f v1 = points[1] - points[0];
Expand All @@ -1117,8 +1116,6 @@ void CCheckerDetectorImpl::
chartPhy[1] = cv::Point2f(w, 0);
chartPhy[2] = cv::Point2f(w, h);
chartPhy[3] = cv::Point2f(0, h);

size = cv::Size((int)w, (int)h);
}

void CCheckerDetectorImpl::
Expand Down
3 changes: 1 addition & 2 deletions modules/mcc/src/checker_detector.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ class CCheckerDetectorImpl : public CCheckerDetector
private: // methods aux
void get_subbox_chart_physical(
const std::vector<cv::Point2f> &points,
std::vector<cv::Point2f> &chartPhy,
cv::Size &size);
std::vector<cv::Point2f> &chartPhy);

void reduce_array(
const std::vector<float> &x,
Expand Down