Skip to content

Conversation

@jmackay2
Copy link
Contributor

Fixes #3270 .

When using the ceres manifold, we should set the manifold instead of the parameterization.

This was tested by building successfully with the latest ceres, which previously failed.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Contributor

/cc @vrabaud

@vrabaud
Copy link
Contributor

vrabaud commented Jun 10, 2022

Indeed, thx. Just realized that our compilation was not working internally either. Thx !

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution 👍

@opencv-pushbot opencv-pushbot merged commit 4c93cc9 into opencv:3.4 Jun 10, 2022
@jiapei100
Copy link

Yeah... This solved my problem.... Thank you ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make command fails with a conversion error from ceres

6 participants