Skip to content

Conversation

@cudawarped
Copy link
Contributor

@cudawarped cudawarped commented Feb 2, 2022

Main PR: opencv/opencv#21555

Test case for GpuMat::locateROI() added to check GpuMat::dataend calculation.

Dependant on opencv/opencv#21555.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
buildworker:Custom=linux-4,linux-6
build_image:Custom=ubuntu-cuda:18.04

@opencv-pushbot opencv-pushbot merged commit 30156e9 into opencv:4.x Feb 3, 2022
@alalek alalek mentioned this pull request Feb 22, 2022
@cudawarped
Copy link
Contributor Author

Sorry I still don't understand. Is it the naming used depth vs type or the fact that cuda_test.xpp is in the opencv repo and test_gpumat.cpp is in the contrib repo?

To clarify unless I am missing something

CUDA_TEST_P(GpuMat_LocateROI, locateROI)
has
GpuMat src = createMat(size, depth, wholeSizeGold, ofsGold, useRoi);
which uses createMat() defined in cuda_test.hpp as
cv::cuda::GpuMat createMat(cv::Size size, int type, cv::Size& size0, cv::Point& ofs, bool useRoi = false);
and declared in cuda_test.cpp.

This looks good to me, what error is gcc 9 reporting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants