Skip to content

Conversation

@danopdev
Copy link
Contributor

@danopdev danopdev commented Jan 24, 2022

resolves #1578

It's not THE SOLUTION because it does not fix the root cause (I don't know the algorithm) but it's a WORKAROUND to fix indexes out of bounds.
Using this changed I was able to do the inpaint (SHIFTMAP) on the example files.

output_shiftmap

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • [ x ] I agree to contribute to the project under Apache 2 License.
  • [ x ] To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • [ x ] The PR is proposed to proper branch
  • [ x ] There is reference to original bug report and related work
  • [ x ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • [ x ] The feature is well documented and sample code can be built with the project CMake

@danopdev
Copy link
Contributor Author

My bad. Fix tailing spaces.

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alalek alalek merged commit d9e7008 into opencv:4.x Jan 25, 2022
@alalek alalek mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cv::xphoto::inpaint crashed in KDTreeComparator::operator()(int const&, int const&) const

2 participants