freetype: fix call sequence for Harfbuzz #3079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3078
freetype wrapper was calling harfbuzz library in the wrong sequence.
So incorrect guess which is text will be LTR(Left to Right)is happen.
This patch fix it. Correct calling sequence is *1.
This text will be drawn correctly with RTL(Right to Left).
However, it seems that harfbuzz alone is not able to support bidi. *2
So that freetype wrapper cannot draw text with a mixture of LTR and RTL.
And it is difficult for me to test many languages/fonts/texts.
I could only create a patch that wasn't effective enough. I'm sorry.
*1) https://harfbuzz.github.io/a-simple-shaping-example.html
*2) https://harfbuzz.github.io/what-harfbuzz-doesnt-do.html
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.