Skip to content

Commit e223e15

Browse files
committed
Merge pull request #3148 from paroj:ovisup
2 parents 82bd0c6 + a3a2eed commit e223e15

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

modules/ovis/include/opencv2/ovis.hpp

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ class CV_EXPORTS_W WindowScene {
8888
virtual ~WindowScene();
8989

9090
/**
91-
* set window background to custom image
91+
* set window background to custom image/ color
9292
* @param image
9393
*/
9494
CV_WRAP virtual void setBackground(InputArray image) = 0;
@@ -101,21 +101,21 @@ class CV_EXPORTS_W WindowScene {
101101
*
102102
* this way you can add distortion or SSAO effects.
103103
* The effects themselves must be defined inside Ogre .compositor scripts.
104-
* @see addResourceLocation
105104
* @param names compositor names that will be applied in order of appearance
105+
* @see addResourceLocation
106106
*/
107107
CV_WRAP virtual void setCompositors(const std::vector<String>& names) = 0;
108108

109109
/**
110110
* place an entity of a mesh in the scene
111111
*
112112
* the mesh needs to be created beforehand. Either programmatically
113-
* by e.g. @ref createPointCloudMesh or by placing an Ogre .mesh file in a resource location.
114-
* @see addResourceLocation
113+
* by e.g. @ref createPointCloudMesh or by placing the respective file in a resource location.
115114
* @param name entity name
116115
* @param meshname mesh name
117-
* @param rot @ref Rodrigues vector or 3x3 rotation matrix
118116
* @param tvec translation
117+
* @param rot @ref Rodrigues vector or 3x3 rotation matrix
118+
* @see addResourceLocation
119119
*/
120120
CV_WRAP virtual void createEntity(const String& name, const String& meshname,
121121
InputArray tvec = noArray(), InputArray rot = noArray()) = 0;
@@ -131,13 +131,14 @@ class CV_EXPORTS_W WindowScene {
131131
* @param name entity name
132132
* @param prop @ref EntityProperty
133133
* @param value the value
134+
* @param subEntityIdx index of the sub-entity (default: all)
134135
*/
135-
CV_WRAP virtual void setEntityProperty(const String& name, int prop, const Scalar& value) = 0;
136-
137-
/// @overload
138136
CV_WRAP virtual void setEntityProperty(const String& name, int prop, const String& value,
139137
int subEntityIdx = -1) = 0;
140138

139+
/// @overload
140+
CV_WRAP virtual void setEntityProperty(const String& name, int prop, const Scalar& value) = 0;
141+
141142
/**
142143
* get the property of an entity
143144
* @param name entity name
@@ -153,8 +154,8 @@ class CV_EXPORTS_W WindowScene {
153154
* @param K intrinsic matrix
154155
* @param imsize image size
155156
* @param zFar far plane in camera coordinates
156-
* @param rot @ref Rodrigues vector or 3x3 rotation matrix
157157
* @param tvec translation
158+
* @param rot @ref Rodrigues vector or 3x3 rotation matrix
158159
* @param color line color
159160
* @return the extents of the Frustum at far plane, where the top left corner denotes the principal
160161
* point offset
@@ -167,8 +168,8 @@ class CV_EXPORTS_W WindowScene {
167168
/**
168169
* creates a point light in the scene
169170
* @param name entity name
170-
* @param rot @ref Rodrigues vector or 3x3 rotation matrix
171171
* @param tvec translation
172+
* @param rot @ref Rodrigues vector or 3x3 rotation matrix
172173
* @param diffuseColor
173174
* @param specularColor
174175
*/
@@ -180,17 +181,17 @@ class CV_EXPORTS_W WindowScene {
180181
/**
181182
* update entity pose by transformation in the parent coordinate space. (pre-rotation)
182183
* @param name entity name
183-
* @param rot @ref Rodrigues vector or 3x3 rotation matrix
184184
* @param tvec translation
185+
* @param rot @ref Rodrigues vector or 3x3 rotation matrix
185186
*/
186187
CV_WRAP virtual void updateEntityPose(const String& name, InputArray tvec = noArray(),
187188
InputArray rot = noArray()) = 0;
188189

189190
/**
190191
* set entity pose in the world coordinate space.
191192
* @param name enitity name
192-
* @param rot @ref Rodrigues vector or 3x3 rotation matrix
193193
* @param tvec translation
194+
* @param rot @ref Rodrigues vector or 3x3 rotation matrix
194195
* @param invert use the inverse of the given pose
195196
*/
196197
CV_WRAP virtual void setEntityPose(const String& name, InputArray tvec = noArray(),
@@ -263,8 +264,8 @@ class CV_EXPORTS_W WindowScene {
263264

264265
/**
265266
* Sets the current camera pose
266-
* @param rot @ref Rodrigues vector or 3x3 rotation matrix
267267
* @param tvec translation
268+
* @param rot @ref Rodrigues vector or 3x3 rotation matrix
268269
* @param invert use the inverse of the given pose
269270
*/
270271
CV_WRAP virtual void setCameraPose(InputArray tvec = noArray(), InputArray rot = noArray(),

0 commit comments

Comments
 (0)