Skip to content

Commit 1271739

Browse files
Add assets in ValidationResultRead schema (#348)
1 parent 32f9a7c commit 1271739

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

app/schemas/validation.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
from app.schemas.activity import ActivityCreate, ActivityRead, ActivityUpdate
66
from app.schemas.agent import CreatedByUpdatedByMixin
7+
from app.schemas.asset import AssetsMixin
78
from app.schemas.base import (
89
AuthorizationMixin,
910
AuthorizationOptionalPublicMixin,
@@ -36,6 +37,7 @@ class ValidationResultRead(
3637
IdentifiableMixin,
3738
CreatedByUpdatedByMixin,
3839
AuthorizationMixin,
40+
AssetsMixin,
3941
):
4042
pass
4143

app/service/validation_result.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import uuid
22

33
import sqlalchemy as sa
4-
from sqlalchemy.orm import joinedload, raiseload
4+
from sqlalchemy.orm import joinedload, raiseload, selectinload
55

66
from app.db.model import Subject, ValidationResult
77
from app.dependencies.auth import UserContextDep, UserContextWithProjectIdDep
@@ -23,6 +23,7 @@ def _load(query: sa.Select):
2323
joinedload(Subject.species),
2424
joinedload(ValidationResult.created_by),
2525
joinedload(ValidationResult.updated_by),
26+
selectinload(ValidationResult.assets),
2627
raiseload("*"),
2728
)
2829

tests/test_validation_result.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ def _assert_read_response(data, json_data):
3535
assert data["validated_entity_id"] == json_data["validated_entity_id"]
3636
assert data["created_by"]["id"] == data["updated_by"]["id"]
3737
assert data["creation_date"] == data["update_date"]
38+
assert "assets" in data
3839

3940

4041
def test_read_one(client: TestClient, validation_result_id, json_data):

0 commit comments

Comments
 (0)