Hotfix notebook (#789)

Author: g-bar

src/app/app/virtual-lab/lab/[virtualLabId]/project/[projectId]/(pages)/notebooks/member/UserNotebookPage.tsx

@@ -62,13 +62,16 @@ export default function UserNotebookPage({
   );
   const [loading, setLoading] = useDelayedLoading(false);
   const [deleteNotebookId, setDeleteNotebookId] = useState('');
+  const errorShown = useRef(false);
 
-  if (serverError)
+  if (serverError !== '' && !errorShown.current) {
     notification.error({
       message: serverError,
       key: 'user-notebook-server-error',
       placement: 'topRight',
     });
+    errorShown.current = true;
+  }
 
   const resetModal = () => {
     setOpenModal(false);
@@ -257,7 +260,7 @@ export default function UserNotebookPage({
                     } catch (e) {
                       notification.error({
                         message: assertErrorMessage(e),
-                        key: 'user-notebook-server-error',
+                        key: 'user-notebook-register-error',
                         placement: 'topRight',
                       });
                       resetModal();

src/app/app/virtual-lab/lab/[virtualLabId]/project/[projectId]/(pages)/notebooks/member/page.tsx

@@ -13,7 +13,7 @@ export default async function Notebooks({
 }: ServerSideComponentProp<{ projectId: string; virtualLabId: string }, any>) {
   const params = await promisedParams;
   const { projectId, virtualLabId } = params;
-  let error = '';
+  let warning = '';
   let initialNotebooks: Notebook[] = [];
 
   try {
@@ -25,22 +25,29 @@ export default async function Notebooks({
 
     const notebooks = NotebooksArraySchema.parse(userNotebookData.data.results);
 
-    const notebooksPromises = notebooks.map((n) => fetchNotebook(n.github_file_url));
+    const notebooksPromises = notebooks.map(async (n) => {
+      try {
+        const notebookData = await fetchNotebook(n.github_file_url);
+        return { ...notebookData, id: n.id, creationDate: n.created_at };
+      } catch (e) {
+        // Collect warning but continue
+        warning = `The notebook ${n.github_file_url} failed to load, please ensure the notebook folder exists and the repository is public`;
+        return null; // skip this notebook
+      }
+    });
 
     const validatedNotebooks = await Promise.all(notebooksPromises);
-    initialNotebooks = validatedNotebooks.map((n, i) => {
-      return { ...n, id: notebooks[i].id, creationDate: notebooks[i].created_at };
-    });
+    initialNotebooks = validatedNotebooks.filter(Boolean) as Notebook[];
   } catch (e) {
-    error = assertErrorMessage(e);
+    warning = assertErrorMessage(e); // fail only if the main list fetch fails
   }
 
   return (
     <UserNotebookPage
       initialNotebooks={initialNotebooks}
       projectId={projectId}
       vlabId={virtualLabId}
-      serverError={error}
+      serverError={warning}
     />
   );
 }

src/util/virtual-lab/fetchNotebooks.ts

@@ -54,6 +54,8 @@ export default async function fetchNotebooks(repoUrl: string, withDate = false)
       return acc;
     }, {});
 
+    let error = '';
+
     for (const item of Object.values(items)) {
       if (item.path.endsWith('analysis_notebook.ipynb')) {
         if (withDate)
@@ -85,9 +87,7 @@ export default async function fetchNotebooks(repoUrl: string, withDate = false)
             objectOfInterest: metadata.input.flatMap((i) => i.data_type.artefact).join(', '),
           });
         } catch (e) {
-          throw new Error(
-            `Error fetching or validating metadata for notebook ${repoUrl} ${item.path} \n ${e}`
-          );
+          error = `Error fetching or validating metadata for notebook ${repoUrl} ${item.path} \n ${e}`;
         }
       }
     }
@@ -102,7 +102,7 @@ export default async function fetchNotebooks(repoUrl: string, withDate = false)
         n.creationDate = dates[i];
         return n;
       }),
-      error: '',
+      error,
     };
   } catch (e) {
     return { notebooks: [], error: assertErrorMessage(e) };