fix type ignores

Author: seratch

src/agents/memory/openai_conversations_session.py

@@ -9,14 +9,19 @@
 
 
 async def start_openai_conversations_session(openai_client: Optional[AsyncOpenAI] = None) -> str:
-    _openai_client = openai_client
+    _maybe_openai_client = openai_client
     if openai_client is None:
-        _openai_client = get_default_openai_client() or AsyncOpenAI()
+        _maybe_openai_client = get_default_openai_client() or AsyncOpenAI()
+    # this never be None here
+    _openai_client: AsyncOpenAI = _maybe_openai_client  # type: ignore [assignment]
 
-    response = await _openai_client.conversations.create(items=[])  # type: ignore [union-attr]
+    response = await _openai_client.conversations.create(items=[])
     return response.id
 
 
+_EMPTY_SESSION_ID = ""
+
+
 class OpenAIConversationsSession(SessionABC):
     def __init__(
         self,
@@ -25,28 +30,30 @@ def __init__(
         openai_client: Optional[AsyncOpenAI] = None,
     ):
         # this implementation allows to set this value later
-        self.session_id = session_id  # type: ignore
-        self.openai_client = openai_client
-        if self.openai_client is None:
-            self.openai_client = get_default_openai_client() or AsyncOpenAI()
+        self.session_id = session_id or _EMPTY_SESSION_ID
+        _openai_client = openai_client
+        if _openai_client is None:
+            _openai_client = get_default_openai_client() or AsyncOpenAI()
+        # this never be None here
+        self.openai_client: AsyncOpenAI = _openai_client
 
     async def _ensure_session_id(self) -> None:
-        if self.session_id is None:
+        if self.session_id == _EMPTY_SESSION_ID:
             self.session_id = await start_openai_conversations_session(self.openai_client)
 
     async def get_items(self, limit: Optional[int] = None) -> list[TResponseInputItem]:
         await self._ensure_session_id()
 
         all_items = []
         if limit is None:
-            async for item in self.openai_client.conversations.items.list(  # type: ignore [union-attr]
+            async for item in self.openai_client.conversations.items.list(
                 conversation_id=self.session_id,
                 order="asc",
             ):
                 # calling model_dump() to make this serializable
                 all_items.append(item.model_dump())
         else:
-            async for item in self.openai_client.conversations.items.list(  # type: ignore [union-attr]
+            async for item in self.openai_client.conversations.items.list(
                 conversation_id=self.session_id,
                 limit=limit,
                 order="desc",
@@ -61,7 +68,7 @@ async def get_items(self, limit: Optional[int] = None) -> list[TResponseInputIte
 
     async def add_items(self, items: list[TResponseInputItem]) -> None:
         await self._ensure_session_id()
-        await self.openai_client.conversations.items.create(  # type: ignore [union-attr]
+        await self.openai_client.conversations.items.create(
             conversation_id=self.session_id,
             items=items,
         )
@@ -71,15 +78,15 @@ async def pop_item(self) -> Optional[TResponseInputItem]:
         items = await self.get_items(limit=1)
         if not items:
             return None
-        await self.openai_client.conversations.items.delete(  # type: ignore [union-attr]
-            conversation_id=self.session_id,
-            item_id=str(items[0]["id"]),  # type: ignore
+        item_id: str = str(items[0]["id"])  # type: ignore [typeddict-item]
+        await self.openai_client.conversations.items.delete(
+            conversation_id=self.session_id, item_id=item_id
         )
         return items[0]
 
     async def clear_session(self) -> None:
         await self._ensure_session_id()
-        await self.openai_client.conversations.delete(  # type: ignore [union-attr]
+        await self.openai_client.conversations.delete(
             conversation_id=self.session_id,
         )
-        self.session_id = None  # type: ignore
+        self.session_id = _EMPTY_SESSION_ID