Lint the code

Author: fcollonval

opentelemetry-api/src/opentelemetry/metrics/_internal/observation.py

@@ -30,7 +30,10 @@ class Observation:
     """
 
     def __init__(
-        self, value: Union[int, float], attributes: Attributes = None, context: Optional[Context] = None
+        self,
+        value: Union[int, float],
+        attributes: Attributes = None,
+        context: Optional[Context] = None,
     ) -> None:
         self._value = value
         self._attributes = attributes
@@ -43,7 +46,7 @@ def value(self) -> Union[float, int]:
     @property
     def attributes(self) -> Attributes:
         return self._attributes
-    
+
     @property
     def context(self) -> Optional[Context]:
         return self._context

opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py

@@ -15,7 +15,10 @@
 
 from opentelemetry.sdk.metrics._internal import Meter, MeterProvider
 from opentelemetry.sdk.metrics._internal.exceptions import MetricsTimeoutError
-from opentelemetry.sdk.metrics._internal.exemplar import ExemplarFilter, ExemplarReservoir
+from opentelemetry.sdk.metrics._internal.exemplar import (
+    ExemplarFilter,
+    ExemplarReservoir,
+)
 from opentelemetry.sdk.metrics._internal.instrument import Counter
 from opentelemetry.sdk.metrics._internal.instrument import Gauge as _Gauge
 from opentelemetry.sdk.metrics._internal.instrument import (

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/__init__.py

@@ -35,7 +35,10 @@
 from opentelemetry.metrics import _Gauge as APIGauge
 from opentelemetry.sdk.environment_variables import OTEL_SDK_DISABLED
 from opentelemetry.sdk.metrics._internal.exceptions import MetricsTimeoutError
-from opentelemetry.sdk.metrics._internal.exemplar import ExemplarFilter, TraceBasedExemplarFilter
+from opentelemetry.sdk.metrics._internal.exemplar import (
+    ExemplarFilter,
+    TraceBasedExemplarFilter,
+)
 from opentelemetry.sdk.metrics._internal.instrument import (
     _Counter,
     _Gauge,
@@ -392,7 +395,11 @@ def __init__(
         if resource is None:
             resource = Resource.create({})
         self._sdk_config = SdkConfiguration(
-            exemplar_filter = TraceBasedExemplarFilter() if exemplar_filter is None else exemplar_filter,
+            exemplar_filter=(
+                TraceBasedExemplarFilter()
+                if exemplar_filter is None
+                else exemplar_filter
+            ),
             resource=resource,
             metric_readers=metric_readers,
             views=views,

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/_view_instrument_match.py

@@ -52,13 +52,19 @@ def __init__(
         )
         if not isinstance(self._view._aggregation, DefaultAggregation):
             self._aggregation = self._view._aggregation._create_aggregation(
-                self._instrument, None, self._view._exemplar_reservoir_factory, 0
+                self._instrument,
+                None,
+                self._view._exemplar_reservoir_factory,
+                0,
             )
         else:
             self._aggregation = self._instrument_class_aggregation[
                 self._instrument.__class__
             ]._create_aggregation(
-                self._instrument, None, self._view._exemplar_reservoir_factory, 0
+                self._instrument,
+                None,
+                self._view._exemplar_reservoir_factory,
+                0,
             )
 
     def conflicts(self, other: "_ViewInstrumentMatch") -> bool:
@@ -83,7 +89,9 @@ def conflicts(self, other: "_ViewInstrumentMatch") -> bool:
         return result
 
     # pylint: disable=protected-access
-    def consume_measurement(self, measurement: Measurement, should_sample_exemplar: bool = True) -> None:
+    def consume_measurement(
+        self, measurement: Measurement, should_sample_exemplar: bool = True
+    ) -> None:
 
         if self._view._attribute_keys is not None:
 
@@ -124,7 +132,9 @@ def consume_measurement(self, measurement: Measurement, should_sample_exemplar:
                         )
                     self._attributes_aggregation[aggr_key] = aggregation
 
-        self._attributes_aggregation[aggr_key].aggregate(measurement, should_sample_exemplar)
+        self._attributes_aggregation[aggr_key].aggregate(
+            measurement, should_sample_exemplar
+        )
 
     def collect(
         self,

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py

@@ -35,7 +35,10 @@
     UpDownCounter,
     _Gauge,
 )
-from opentelemetry.sdk.metrics._internal.exemplar import Exemplar, ExemplarReservoirFactory
+from opentelemetry.sdk.metrics._internal.exemplar import (
+    Exemplar,
+    ExemplarReservoirFactory,
+)
 from opentelemetry.sdk.metrics._internal.exponential_histogram.buckets import (
     Buckets,
 )
@@ -82,13 +85,19 @@ class AggregationTemporality(IntEnum):
 
 
 class _Aggregation(ABC, Generic[_DataPointVarT]):
-    def __init__(self, attributes: Attributes, reservoir_factory: ExemplarReservoirFactory):
+    def __init__(
+        self,
+        attributes: Attributes,
+        reservoir_factory: ExemplarReservoirFactory,
+    ):
         self._lock = Lock()
         self._attributes = attributes
         self._reservoir = reservoir_factory()
         self._previous_point = None
 
-    def aggregate(self, measurement: Measurement, should_sample_exemplar: bool = True) -> None:
+    def aggregate(
+        self, measurement: Measurement, should_sample_exemplar: bool = True
+    ) -> None:
         if should_sample_exemplar:
             self._reservoir.offer(
                 measurement.value,
@@ -112,7 +121,9 @@ def _collect_exemplars(self) -> Sequence[Exemplar]:
 
 
 class _DropAggregation(_Aggregation):
-    def aggregate(self, measurement: Measurement, should_sample_exemplar: bool = True) -> None:
+    def aggregate(
+        self, measurement: Measurement, should_sample_exemplar: bool = True
+    ) -> None:
         pass
 
     def collect(
@@ -135,15 +146,19 @@ def __init__(
         super().__init__(attributes, reservoir_factory)
 
         self._start_time_unix_nano = start_time_unix_nano
-        self._instrument_aggregation_temporality = instrument_aggregation_temporality
+        self._instrument_aggregation_temporality = (
+            instrument_aggregation_temporality
+        )
         self._instrument_is_monotonic = instrument_is_monotonic
 
         self._value = None
 
         self._previous_collection_start_nano = self._start_time_unix_nano
         self._previous_value = 0
 
-    def aggregate(self, measurement: Measurement, should_sample_exemplar: bool = True) -> None:
+    def aggregate(
+        self, measurement: Measurement, should_sample_exemplar: bool = True
+    ) -> None:
         with self._lock:
             if self._value is None:
                 self._value = 0
@@ -363,14 +378,20 @@ def collect(
 
 
 class _LastValueAggregation(_Aggregation[GaugePoint]):
-    def __init__(self, attributes: Attributes, reservoir_factory: ExemplarReservoirFactory):
+    def __init__(
+        self,
+        attributes: Attributes,
+        reservoir_factory: ExemplarReservoirFactory,
+    ):
         super().__init__(attributes, reservoir_factory)
         self._value = None
 
-    def aggregate(self, measurement: Measurement, should_sample_exemplar: bool = True):
+    def aggregate(
+        self, measurement: Measurement, should_sample_exemplar: bool = True
+    ):
         with self._lock:
             self._value = measurement.value
-        
+
             super().aggregate(measurement, should_sample_exemplar)
 
     def collect(
@@ -424,7 +445,12 @@ def __init__(
         ),
         record_min_max: bool = True,
     ):
-        super().__init__(attributes, reservoir_factory=partial(reservoir_factory, boundaries=boundaries))
+        super().__init__(
+            attributes,
+            reservoir_factory=partial(
+                reservoir_factory, boundaries=boundaries
+            ),
+        )
 
         self._instrument_aggregation_temporality = (
             instrument_aggregation_temporality
@@ -448,7 +474,9 @@ def __init__(
     def _get_empty_bucket_counts(self) -> List[int]:
         return [0] * (len(self._boundaries) + 1)
 
-    def aggregate(self, measurement: Measurement, should_sample_exemplar: bool = True) -> None:
+    def aggregate(
+        self, measurement: Measurement, should_sample_exemplar: bool = True
+    ) -> None:
 
         with self._lock:
             if self._value is None:
@@ -615,7 +643,12 @@ def __init__(
         # _ExplicitBucketHistogramAggregation both size and amount of buckets
         # remain constant once it is instantiated).
 
-        super().__init__(attributes, reservoir_factory=partial(reservoir_factory, size=min(20, max_size)))
+        super().__init__(
+            attributes,
+            reservoir_factory=partial(
+                reservoir_factory, size=min(20, max_size)
+            ),
+        )
 
         self._instrument_aggregation_temporality = (
             instrument_aggregation_temporality
@@ -646,7 +679,9 @@ def __init__(
 
         self._mapping = self._new_mapping(self._max_scale)
 
-    def aggregate(self, measurement: Measurement, should_sample_exemplar: bool = True) -> None:
+    def aggregate(
+        self, measurement: Measurement, should_sample_exemplar: bool = True
+    ) -> None:
         # pylint: disable=too-many-branches,too-many-statements, too-many-locals
 
         with self._lock:
@@ -1147,7 +1182,9 @@ def _create_aggregation(
         self,
         instrument: Instrument,
         attributes: Attributes,
-        reservoir_factory: Callable[[Type[_Aggregation]], ExemplarReservoirFactory],
+        reservoir_factory: Callable[
+            [Type[_Aggregation]], ExemplarReservoirFactory
+        ],
         start_time_unix_nano: int,
     ) -> _Aggregation:
         """Creates an aggregation"""
@@ -1176,7 +1213,9 @@ def _create_aggregation(
         self,
         instrument: Instrument,
         attributes: Attributes,
-        reservoir_factory: Callable[[Type[_Aggregation]], ExemplarReservoirFactory],
+        reservoir_factory: Callable[
+            [Type[_Aggregation]], ExemplarReservoirFactory
+        ],
         start_time_unix_nano: int,
     ) -> _Aggregation:
 
@@ -1227,18 +1266,26 @@ def _create_aggregation(
         if isinstance(instrument, Histogram):
             return _ExplicitBucketHistogramAggregation(
                 attributes,
-                reservoir_factory=reservoir_factory(_ExplicitBucketHistogramAggregation),
+                reservoir_factory=reservoir_factory(
+                    _ExplicitBucketHistogramAggregation
+                ),
                 instrument_aggregation_temporality=(
                     AggregationTemporality.DELTA
                 ),
                 start_time_unix_nano=start_time_unix_nano,
             )
 
         if isinstance(instrument, ObservableGauge):
-            return _LastValueAggregation(attributes, reservoir_factory=reservoir_factory(_LastValueAggregation))
+            return _LastValueAggregation(
+                attributes,
+                reservoir_factory=reservoir_factory(_LastValueAggregation),
+            )
 
         if isinstance(instrument, _Gauge):
-            return _LastValueAggregation(attributes, reservoir_factory=reservoir_factory(_LastValueAggregation))
+            return _LastValueAggregation(
+                attributes,
+                reservoir_factory=reservoir_factory(_LastValueAggregation),
+            )
 
         # pylint: disable=broad-exception-raised
         raise Exception(f"Invalid instrument type {type(instrument)} found")
@@ -1257,7 +1304,9 @@ def _create_aggregation(
         self,
         instrument: Instrument,
         attributes: Attributes,
-        reservoir_factory: Callable[[Type[_Aggregation]], ExemplarReservoirFactory],
+        reservoir_factory: Callable[
+            [Type[_Aggregation]], ExemplarReservoirFactory
+        ],
         start_time_unix_nano: int,
     ) -> _Aggregation:
 
@@ -1321,7 +1370,9 @@ def _create_aggregation(
         self,
         instrument: Instrument,
         attributes: Attributes,
-        reservoir_factory: Callable[[Type[_Aggregation]], ExemplarReservoirFactory],
+        reservoir_factory: Callable[
+            [Type[_Aggregation]], ExemplarReservoirFactory
+        ],
         start_time_unix_nano: int,
     ) -> _Aggregation:
 
@@ -1353,7 +1404,9 @@ def _create_aggregation(
         self,
         instrument: Instrument,
         attributes: Attributes,
-        reservoir_factory: Callable[[Type[_Aggregation]], ExemplarReservoirFactory],
+        reservoir_factory: Callable[
+            [Type[_Aggregation]], ExemplarReservoirFactory
+        ],
         start_time_unix_nano: int,
     ) -> _Aggregation:
 
@@ -1386,10 +1439,15 @@ def _create_aggregation(
         self,
         instrument: Instrument,
         attributes: Attributes,
-        reservoir_factory: Callable[[Type[_Aggregation]], ExemplarReservoirFactory],
+        reservoir_factory: Callable[
+            [Type[_Aggregation]], ExemplarReservoirFactory
+        ],
         start_time_unix_nano: int,
     ) -> _Aggregation:
-        return _LastValueAggregation(attributes, reservoir_factory=reservoir_factory(_LastValueAggregation))
+        return _LastValueAggregation(
+            attributes,
+            reservoir_factory=reservoir_factory(_LastValueAggregation),
+        )
 
 
 class DropAggregation(Aggregation):
@@ -1399,7 +1457,11 @@ def _create_aggregation(
         self,
         instrument: Instrument,
         attributes: Attributes,
-        reservoir_factory: Callable[[Type[_Aggregation]], ExemplarReservoirFactory],
+        reservoir_factory: Callable[
+            [Type[_Aggregation]], ExemplarReservoirFactory
+        ],
         start_time_unix_nano: int,
     ) -> _Aggregation:
-        return _DropAggregation(attributes, reservoir_factory(_DropAggregation))
+        return _DropAggregation(
+            attributes, reservoir_factory(_DropAggregation)
+        )

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exemplar/__init__.py

@@ -14,9 +14,9 @@
 
 from .exemplar import Exemplar
 from .exemplar_filter import (
-    ExemplarFilter,
     AlwaysOffExemplarFilter,
     AlwaysOnExemplarFilter,
+    ExemplarFilter,
     TraceBasedExemplarFilter,
 )
 from .exemplar_reservoir import (

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exemplar/exemplar.py

@@ -37,9 +37,9 @@ class Exemplar:
         https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/data-model.md#exemplars
         https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#exemplar
     """
+
     filtered_attributes: Attributes
     value: Union[int, float]
     time_unix_nano: int
     span_id: Optional[str] = None
     trace_id: Optional[str] = None
-