Skip to content

Commit 684c5ad

Browse files
dashpoleMrAlias
andauthored
Apply suggestions from code review
Co-authored-by: Tyler Yahn <[email protected]>
1 parent cb346ca commit 684c5ad

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

detectors/gcp/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ tp := trace.NewTracerProvider(
3737
## Setting Kubernetes attributes
3838

3939
Previous iterations of GCP resource detection attempted to detect
40-
container.name, k8s.pod.name and k8s.namespace.name. When using this detector,
40+
`container.name`, `k8s.pod.name` and `k8s.namespace.name`. When using this detector,
4141
you should use this in your Pod Spec to set these using
42-
OTEL_RESOURCE_ATTRIBUTES:
42+
`OTEL_RESOURCE_ATTRIBUTES`:
4343

4444
```yaml
4545
env:

detectors/gcp/types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ package gcp // import "go.opentelemetry.io/contrib/detectors/gcp"
1616

1717
import "github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp"
1818

19-
// gcpDetector can detect attributes of GCP environments
19+
// gcpDetector can detect attributes of GCP environments.
2020
type gcpDetector interface {
2121
ProjectID() (string, error)
2222
CloudPlatform() gcp.Platform

0 commit comments

Comments
 (0)