From d3a57360cbb880b729780439a127c38bd0ff4a31 Mon Sep 17 00:00:00 2001 From: Valentin Petrov Date: Wed, 20 Jan 2021 02:42:13 -0800 Subject: [PATCH] PML/UCX: don't do pml_check_selected call Current implementation of pml check protocol causes extra dmodex exchanges that may result in a significant performance degradation for some workloads (corresponds to master 36b64cb35003e3e5df0ffc2432ee7fe3633f7bb6) Signed-off-by: Valentin Petrov --- ompi/mca/pml/ucx/pml_ucx.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/ompi/mca/pml/ucx/pml_ucx.c b/ompi/mca/pml/ucx/pml_ucx.c index 6645c61a6c0..05b351007d4 100644 --- a/ompi/mca/pml/ucx/pml_ucx.c +++ b/ompi/mca/pml/ucx/pml_ucx.c @@ -410,17 +410,7 @@ static ucp_ep_h mca_pml_ucx_add_proc_common(ompi_proc_t *proc) static ucp_ep_h mca_pml_ucx_add_proc(ompi_communicator_t *comm, int dst) { - ompi_proc_t *proc0 = ompi_comm_peer_lookup(comm, 0); ompi_proc_t *proc_peer = ompi_comm_peer_lookup(comm, dst); - int ret; - - /* Note, mca_pml_base_pml_check_selected, doesn't use 3rd argument */ - if (OMPI_SUCCESS != (ret = mca_pml_base_pml_check_selected("ucx", - &proc0, - dst))) { - return NULL; - } - return mca_pml_ucx_add_proc_common(proc_peer); } @@ -429,13 +419,6 @@ int mca_pml_ucx_add_procs(struct ompi_proc_t **procs, size_t nprocs) ompi_proc_t *proc; ucp_ep_h ep; size_t i; - int ret; - - if (OMPI_SUCCESS != (ret = mca_pml_base_pml_check_selected("ucx", - procs, - nprocs))) { - return ret; - } for (i = 0; i < nprocs; ++i) { proc = procs[(i + OMPI_PROC_MY_NAME->vpid) % nprocs];