From 36b64cb35003e3e5df0ffc2432ee7fe3633f7bb6 Mon Sep 17 00:00:00 2001 From: Valentin Petrov Date: Wed, 20 Jan 2021 10:06:46 -0800 Subject: [PATCH] PML/UCX: don't do pml_check_selected call Current implementation of pml check protocol causes extra dmodex exchanges that may result in a significant performance degradation for some workloads Signed-off-by: Valentin Petrov --- ompi/mca/pml/ucx/pml_ucx.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/ompi/mca/pml/ucx/pml_ucx.c b/ompi/mca/pml/ucx/pml_ucx.c index 78e1660f25c..f839399407c 100644 --- a/ompi/mca/pml/ucx/pml_ucx.c +++ b/ompi/mca/pml/ucx/pml_ucx.c @@ -417,13 +417,6 @@ int mca_pml_ucx_add_procs(struct ompi_proc_t **procs, size_t nprocs) ompi_proc_t *proc; ucp_ep_h ep; size_t i; - int ret; - - if (OMPI_SUCCESS != (ret = mca_pml_base_pml_check_selected("ucx", - procs, - nprocs))) { - return ret; - } for (i = 0; i < nprocs; ++i) { proc = procs[(i + OMPI_PROC_MY_NAME->vpid) % nprocs]; @@ -448,13 +441,6 @@ static inline ucp_ep_h mca_pml_ucx_get_ep(ompi_communicator_t *comm, int rank) return ep; } - /* Note, mca_pml_base_pml_check_selected, doesn't use 3rd argument */ - if (OMPI_SUCCESS != mca_pml_base_pml_check_selected("ucx", - &proc_peer, - 1)) { - return NULL; - } - return mca_pml_ucx_add_proc_common(proc_peer); }