Shmem: rename realloc/free in segment_allocator to avoid name clash with memory debugging

[devreal]

The tokens realloc and free are overridden by Open MPI's memory debugging facility, leading to build errors if enabled. This PR renames struct members in the shmem segment_allocator to reallocate and release to avoid the name clash.

Fixes #7925

Signed-off-by: Joseph Schuchart [email protected]

[bertwesarg]

@devreal could you figure out why the jenkins build fails. I clicked everything through but could not found any error.

[devreal]

Mhh, not sure why that fails. In the logs I see:

+ /bin/sh open-mpi-build-script.sh
open-mpi-build-script.sh: 1: open-mpi-build-script.sh: 500:: not found
Build step 'Execute shell' marked build as failure
Finished: FAILURE

[jsquyres]

That's a weird one. Let's see if it was a transient error.

bot:aws:retest

[devreal]

Thanks @jsquyres, tests seem to have succeeded.

[devreal]

@yosefe Could you please review this one?

[awlauria]

We hit this recently and applied a similar fix. Thanks for pushing it upstream.

[awlauria]

Unlikely as it may be, we could also prepend these with oshmen_ or similar to make it more bullet-proof.

[jsquyres]

@bertwesarg @devreal Can you guys figure out which of this PR and #7926 should get merged? They're fairly straightforward and have been sitting around forever. Thanks!

[awlauria]

#7926 merged, so closing this.