Remove unused opal_shmem_seg_hdr_t to retain alignment #7207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseph Schuchart <[email protected]>
bosilca
approved these changes
Jan 13, 2020
Contributor
Author
|
Should this be cherry-picked to the release branches? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #6950, the
opal_shmem_seg_hdr_tstruct allocated at the beginning of each shared memory segment is not actually used but interferes with the alignment of the memory. This PR removes this struct, allowing theshmemcomponents to return page-aligned memory.Fixes #6950
Signed-off-by: Joseph Schuchart [email protected]