coll/libnbc: revisit NBC_Handle usage #4050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
approved these changes
Aug 8, 2017
Member
|
@ggouaillardet , can you rebase and clean up the merge? |
make NBC_Handle (almost) an internal structure created by NBC_Schedule_request() use a local variable instead of what was previously handle->tmpbuf Refs open-mpi#3487 Signed-off-by: Gilles Gouaillardet <[email protected]> (back-ported from commit open-mpi/ompi@9ba85b8)
ggouaillardet
force-pushed
the
topic/v3.0.x/libnbc_revamp
branch
from
b01e4d6 to
cc8de6e
Compare
Contributor
Author
|
@bwbarrett done, that was just a trivial conflict of copyrights |
hppritcha
reviewed
Sep 20, 2017
| vpeer = vrank + (1 << (r - 1)); | ||
| VRANK2RANK(peer, vpeer, vroot) | ||
| if (peer < p) { | ||
| int tbuf; |
Member
There was a problem hiding this comment.
what is tbuf being used for? maybe github diff is confusing me?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make NBC_Handle (almost) an internal structure created
by NBC_Schedule_request()
use a local variable instead of what was previously handle->tmpbuf
Refs #3487
Signed-off-by: Gilles Gouaillardet [email protected]
(cherry picked from commit 9ba85b8)