Skip to content

ompi/communicator: do not use MPI_IN_PLACE for iallreduce callback #12246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024
Merged

ompi/communicator: do not use MPI_IN_PLACE for iallreduce callback #12246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ompi/communicator/comm_cid.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ struct ompi_comm_cid_context_t {
int remote_leader;
int iter;
/** storage for activate barrier */
int local_peers;
int max_local_peers;
char *port_string;
bool send_first;
Expand Down Expand Up @@ -266,7 +267,8 @@ static ompi_comm_cid_context_t *mca_comm_cid_context_alloc (ompi_communicator_t

context->send_first = send_first;
context->iter = 0;
context->max_local_peers = ompi_group_count_local_peers(newcomm->c_local_group);
context->local_peers = ompi_group_count_local_peers(newcomm->c_local_group);
context->max_local_peers = -1;

return context;
}
Expand Down Expand Up @@ -908,8 +910,12 @@ int ompi_comm_activate_nb (ompi_communicator_t **newcomm, ompi_communicator_t *c
}

if (OMPI_COMM_IS_INTRA(*newcomm)) {
/* The communicator's disjointness is inferred from max_local_peers. */
ret = context->iallreduce_fn (MPI_IN_PLACE, &context->max_local_peers, 1, MPI_MAX, context,
/**
* The communicator's disjointness is inferred from max_local_peers.
* Note: MPI_IN_PLACE cannot be used here because the parent could be an
* inter-communicator
*/
ret = context->iallreduce_fn (&context->local_peers, &context->max_local_peers, 1, MPI_MAX, context,
&subreq);
if (OMPI_SUCCESS != ret) {
ompi_comm_request_return (request);
Expand All @@ -919,7 +925,7 @@ int ompi_comm_activate_nb (ompi_communicator_t **newcomm, ompi_communicator_t *c
} else {
ompi_comm_request_schedule_append (request, ompi_comm_activate_nb_complete, NULL, 0);
}

ompi_comm_request_start (request);

*req = &request->super;
Expand Down