mtl/ofi: Remove unused variables, and check ompi_ret #11686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
FWIW: We typically uniquely identify the Coverity issue(s) found and fixed in the Git commit messages. E.g., "CID 12345". |
lrbison
force-pushed
the
coverity
branch
2 times, most recently
from
812e04a to
294d018
Compare
jsquyres
approved these changes
May 16, 2023
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
I can attest to the fact that the CID messages are in the commit messages, but another OFI person should review the content of the code changes. They look nominally correct to me, but I have no way of testing them.
hppritcha
approved these changes
Jun 22, 2023
Contributor
Author
|
This is old enough I will rebase it. Thank you for the reviews. |
Contributor
|
@lrbison Any plan to merge this? |
Contributor
Author
|
Forgot about this one. Let me rebase and merge it. Thanks for the reminder! |
added 2 commits
January 9, 2024 16:15
Correct Coverity issue CID 1515755. Signed-off-by: Luke Robison <[email protected]>
Correct Coverity CID 1515761. Remove unused variable found by GCC (namelen). Signed-off-by: Luke Robison <[email protected]>
Contributor
Author
|
Rebased this morning and built cleanly. This is ready for merge, but NVIDIA CI failed during checkout it seems. @janjust Can you take a look at NVIDIA CI? |
Contributor
|
Running AWS internal CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two issues in mtl/ofi found by Coverity.