From 6b2887955f2be60a378021abbedc2526554eda01 Mon Sep 17 00:00:00 2001 From: Joseph Schuchart Date: Fri, 21 Oct 2022 10:41:46 -0400 Subject: [PATCH] Fix potential oob read in mca_coll_han_query_module_from_mca Reported as CID 1516096. Signed-off-by: Joseph Schuchart --- ompi/mca/coll/han/coll_han_component.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ompi/mca/coll/han/coll_han_component.c b/ompi/mca/coll/han/coll_han_component.c index 99106c3f3c9..170a79bc752 100644 --- a/ompi/mca/coll/han/coll_han_component.c +++ b/ompi/mca/coll/han/coll_han_component.c @@ -187,9 +187,8 @@ mca_coll_han_query_module_from_mca(mca_base_component_t* c, { char *module_name, *endptr = NULL; - int mod_id = COMPONENTS_COUNT; + int mod_id = COMPONENTS_COUNT-1; mod_id = (*module_id > (uint32_t)mod_id) ? mod_id : (int)*module_id; /* stay in range */ - mod_id = (mod_id < 0) ? 0 : mod_id; /* in range */ *storage = available_components[mod_id].component_name;